From: Dave Chinner <david@fromorbit.com>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Ben Myers <bpm@sgi.com>,
xfs@oss.sgi.com, Christoph Hellwig <hch@lst.de>,
Dave Chinner <dchinner@redhat.com>
Subject: Re: [xfs:for-next 72/74] fs/xfs/xfs_log.c:1709:32: sparse: incorrect type in assignment (different base types)
Date: Wed, 28 Nov 2012 12:00:05 +1100 [thread overview]
Message-ID: <20121128010005.GQ6434@dastard> (raw)
In-Reply-To: <50b45f45.SLR36oqX9vHupAe2%fengguang.wu@intel.com>
On Tue, Nov 27, 2012 at 02:35:49PM +0800, kbuild test robot wrote:
> tree: git://oss.sgi.com/xfs/xfs for-next
> head: 7c4cebe8e02dd0b0e655605442bbe9268db9ed4f
> commit: 0e446be44806240c779666591bb9e8cb0e86a50d [72/74] xfs: add CRC checks to the log
>
>
> sparse warnings:
>
> + fs/xfs/xfs_log.c:1709:32: sparse: incorrect type in assignment (different base types)
> fs/xfs/xfs_log.c:1709:32: expected restricted __le32 [usertype] h_crc
> fs/xfs/xfs_log.c:1709:32: got restricted __be32
> + fs/xfs/xfs_log.c:1568:29: sparse: incorrect type in return expression (different base types)
> fs/xfs/xfs_log.c:1568:29: expected restricted __be32
> fs/xfs/xfs_log.c:1568:29: got restricted __le32
> fs/xfs/xfs_log.c:267:17: sparse: context imbalance in 'xlog_grant_head_wait' - unexpected unlock
> --
> + fs/xfs/xfs_log_recover.c:3239:13: sparse: restricted __be32 degrades to integer
> + fs/xfs/xfs_log_recover.c:3239:25: sparse: restricted __le32 degrades to integer
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast to restricted __be32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast from restricted __le32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast to restricted __be32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast from restricted __le32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast to restricted __be32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast from restricted __le32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast to restricted __be32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast from restricted __le32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast to restricted __be32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast from restricted __le32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast to restricted __be32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast from restricted __le32
Hmmm, why wasn't my sparse runs picking this up?
/me upgrades sparse from current git
Oh, look, they show up now. I'll get them fixed.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-11-28 0:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 6:35 [xfs:for-next 72/74] fs/xfs/xfs_log.c:1709:32: sparse: incorrect type in assignment (different base types) kbuild test robot
2012-11-28 1:00 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121128010005.GQ6434@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=dchinner@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox