From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id qASMOpdD218569 for ; Wed, 28 Nov 2012 16:24:51 -0600 Received: from eagdhcp-232-125.americas.sgi.com (eagdhcp-232-125.americas.sgi.com [128.162.232.125]) by relay3.corp.sgi.com (Postfix) with ESMTP id BC799AC003 for ; Wed, 28 Nov 2012 14:27:05 -0800 (PST) Received: from eagdhcp-232-125.americas.sgi.com (localhost [127.0.0.1]) by eagdhcp-232-125.americas.sgi.com (8.14.5/8.14.5) with ESMTP id qASMR5Ti003583 for ; Wed, 28 Nov 2012 16:27:05 -0600 (CST) (envelope-from tinguely@sgi.com) Message-Id: <20121128222309.109033307@.sgi.com> Date: Wed, 28 Nov 2012 16:23:09 -0600 From: Mark Tinguely Subject: [PATCH v2 0/3] discontiguous buffer patches List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: xfs@oss.sgi.com Eric Sundeen's "userspace vs. fragmented multiblock dir2", xfstest 291 commit 2a4ed, causes a xfs_buf lock hang: [] down+0x47/0x50 [] xfs_buf_lock+0x66/0xe0 [xfs] [] _xfs_buf_find+0x1f9/0x320 [xfs] [] xfs_buf_get_map+0x2f/0x170 [xfs] [] xfs_buf_read_map+0x2a/0x100 [xfs] [] xfs_trans_read_buf_map+0x3b0/0x590 [xfs] [] xfs_da_read_buf+0xbe/0x230 [xfs] [] xfs_dir2_block_addname+0x7c/0x980 [xfs] [] xfs_dir2_sf_addname+0x3e8/0x450 [xfs] [] xfs_dir_createname+0x17c/0x1e0 [xfs] [] xfs_create+0x4c2/0x5f0 [xfs] [] xfs_vn_mknod+0x8a/0x1a0 [xfs] [] xfs_vn_create+0xe/0x10 [xfs] [] vfs_create+0xac/0xd0 [] do_last+0x8be/0x960 [] path_openat+0xdc/0x410 [] do_filp_open+0x43/0xa0 [] do_sys_open+0x152/0x1e0 [] sys_open+0x1c/0x20 [] system_call_fastpath+0x16/0x1b [] 0xffffffffffffffff That bisect a problem to the discontiguous xfs_buf support series. xfs_trans_buf_item_match() is looking for the block number of the buffer in the single segment map area. After fixing the b_map issue, there were couple asserts associated with the buffer log format not correctly using the bli_formats[] structure. Changes to the series from version 1: Patch 1: Moved b_map structure to __b_map to avoid future confusion per Christoph's suggestion. Patch 2: Moved bli_format structure to __bli_format to avoid future confusion per Christoph's suggestion. Removed the buffer XFS_TRANS_DEBUG routines per Dave's suggestion. Patch 3: Moved the detection of an empty format to a new file and add parenthesis per Dave's suggestion. Cleared all buffer log formats per Dave's suggestion. --Mark. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs