Re: [PATCH] xfstests: Ensure cmdline geometry puts mkfs.xfs into multidisk mode

Christoph Hellwig
2012-12-08T11:57:43Z

On Thu, Dec 06, 2012 at 04:02:16PM -0600, Eric Sandeen wrote:
> Ensure that when mkfs.xfs is invoked with commandline geometry, it
> triggers multidisk mode and creates more AGs.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

> Maybe this should also test device-specified geometry, but not sure
> how to do that easily within xfstests, any ideas?

That would involved scsi_debug so that we could set them up. We had
several ideas how to use scsi debug for these sort of tests but never
really bothered to do it. If you have some spare cycles I'd love to see
this sort of tests.