From: Christoph Hellwig <hch@infradead.org>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v3 1/5] xfs: use b_maps[] for discontiguous buffers
Date: Sat, 8 Dec 2012 07:23:35 -0500 [thread overview]
Message-ID: <20121208122335.GA29107@infradead.org> (raw)
In-Reply-To: <20121204224938.599314438@sgi.com>
On Tue, Dec 04, 2012 at 05:18:02PM -0600, Mark Tinguely wrote:
> Commits starting at 77c1a08 introduced a multiple segment support
> to xfs_buf. xfs_trans_buf_item_match() could not find a multi-segment
> buffer in the transaction because it was looking at the single segment
> block number rather than the multi-segment b_maps[0].bm.bn. This
> results on a recursive buffer lock that can never be satisfied.
>
> This patch:
> 1) Changed the remaining b_map accesses to be b_maps[0] accesses.
> 2) Renames the single segment b_map structure to __b_map to avoid
> future confusion.
>
> Signed-off-by: Mark Tinguely <tinguely@sgi.com>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-12-08 12:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 23:18 [PATCH v3 0/5] discontiguous buffer patches Mark Tinguely
2012-12-04 23:18 ` [PATCH v3 1/5] xfs: use b_maps[] for discontiguous buffers Mark Tinguely
2012-12-08 12:23 ` Christoph Hellwig [this message]
2012-12-04 23:18 ` [PATCH v3 2/5] xfs: rename bli_format to avoid confusion with bli_formats Mark Tinguely
2012-12-08 12:23 ` Christoph Hellwig
2012-12-04 23:18 ` [PATCH v3 3/5] xfs: fix segment in xfs_buf_item_format_segment Mark Tinguely
2012-12-08 12:29 ` Christoph Hellwig
2012-12-10 1:34 ` Dave Chinner
2012-12-04 23:18 ` [PATCH v3 4/5] xfs: fix the multi-segment log buffer format Mark Tinguely
2012-12-08 12:38 ` Christoph Hellwig
2012-12-10 1:59 ` Dave Chinner
2012-12-04 23:18 ` [PATCH v3 5/5] xfs remove the XFS_TRANS_DEBUG routines Mark Tinguely
2012-12-08 12:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121208122335.GA29107@infradead.org \
--to=hch@infradead.org \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox