From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id qB8CL9Ql031206 for ; Sat, 8 Dec 2012 06:21:09 -0600 Date: Sat, 8 Dec 2012 07:23:35 -0500 From: Christoph Hellwig Subject: Re: [PATCH v3 1/5] xfs: use b_maps[] for discontiguous buffers Message-ID: <20121208122335.GA29107@infradead.org> References: <20121204231801.982422341@sgi.com> <20121204224938.599314438@sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20121204224938.599314438@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Mark Tinguely Cc: xfs@oss.sgi.com On Tue, Dec 04, 2012 at 05:18:02PM -0600, Mark Tinguely wrote: > Commits starting at 77c1a08 introduced a multiple segment support > to xfs_buf. xfs_trans_buf_item_match() could not find a multi-segment > buffer in the transaction because it was looking at the single segment > block number rather than the multi-segment b_maps[0].bm.bn. This > results on a recursive buffer lock that can never be satisfied. > > This patch: > 1) Changed the remaining b_map accesses to be b_maps[0] accesses. > 2) Renames the single segment b_map structure to __b_map to avoid > future confusion. > > Signed-off-by: Mark Tinguely > Reviewed-by: Dave Chinner Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs