From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@infradead.org>,
Ben England <bengland@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: Ensure cmdline geometry puts mkfs.xfs into multidisk mode
Date: Mon, 10 Dec 2012 10:51:05 +1100 [thread overview]
Message-ID: <20121209235105.GD15784@dastard> (raw)
In-Reply-To: <50C36A83.1040406@sandeen.net>
On Sat, Dec 08, 2012 at 10:27:47AM -0600, Eric Sandeen wrote:
> On 12/8/12 6:00 AM, Christoph Hellwig wrote:
> > On Thu, Dec 06, 2012 at 04:02:16PM -0600, Eric Sandeen wrote:
> >> Ensure that when mkfs.xfs is invoked with commandline geometry, it
> >> triggers multidisk mode and creates more AGs.
> >>
> >> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> >
> > Looks good,
> >
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Thanks
>
> >> Maybe this should also test device-specified geometry, but not sure
> >> how to do that easily within xfstests, any ideas?
> >
> > That would involved scsi_debug so that we could set them up. We had
> > several ideas how to use scsi debug for these sort of tests but never
> > really bothered to do it. If you have some spare cycles I'd love to see
> > this sort of tests.
>
> scsi_debug won't report geometry on its own today; we'd need to assemble
> something out of scsi_debug luns I'm afraid, so it gets even more involved.
>
> We do have a little bit of scsi_debug framework in xfstests today, though,
> so if scsi_debug grew the capability it'd be easy to add.
Does it really need scsi for this? To mkfs.xfs, all devices look the
same, so if you want to make random geometries, wouldn't playing
games with llopback devices and DM be sufficient?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-12-09 23:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 16:34 [PATCH, RFC] mkfs.xfs: go into multidisk mode when geometry is on cmdline Eric Sandeen
2012-11-21 9:56 ` Christoph Hellwig
2012-12-06 21:35 ` [PATCH V2] " Eric Sandeen
2012-12-06 21:52 ` [PATCH V3] " Eric Sandeen
2012-12-08 11:59 ` Christoph Hellwig
2012-12-06 22:02 ` [PATCH] xfstests: Ensure cmdline geometry puts mkfs.xfs into multidisk mode Eric Sandeen
2012-12-08 12:00 ` Christoph Hellwig
2012-12-08 16:27 ` Eric Sandeen
2012-12-09 23:51 ` Dave Chinner [this message]
2012-12-10 0:23 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121209235105.GD15784@dastard \
--to=david@fromorbit.com \
--cc=bengland@redhat.com \
--cc=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox