From: Dave Chinner <david@fromorbit.com>
To: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs ML <xfs@oss.sgi.com>
Subject: Re: [PATCH 2/2] XFS: Mark no-more-exist xfsbufd related sysctl parameters as obsolete.
Date: Mon, 10 Dec 2012 12:30:48 +1100 [thread overview]
Message-ID: <20121210013048.GK15784@dastard> (raw)
In-Reply-To: <50C521D7.5060202@jp.fujitsu.com>
On Mon, Dec 10, 2012 at 08:42:15AM +0900, Satoru Takeuchi wrote:
> From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
>
>
> xfsbufd is removed since commit 43ff2122e6492bcc88b065c433453dce88223b30.
> But there stille be two sysctl parameters about it
> (fs.xfs.{xfsbufd_centisecs,age_buffer_centisecs}.)
>
> This patch marks these parameters as obsolete. In adition, prints
> a warning message if someone tries to use these parameters.
While we currently don't use them, I'm not sure they are obsolete.
We need to integrate the AIL flushing with time-based log idling
(i.e. flushing to an empty state), and part of that work is making
the AIL log items have a age-based flush component.
i.e. how often it will wake to try to flush/idle the log when there
is no pressure, and how long items should wait before being flushed
even when there is activity.
Those two parameters are exactly what the xfsbufd parameters have
historically controlled, so rather than introduce new sysctls for
the same purpose, I was planning on just re-using them. Hence I
suspect that marking them obsolete is probably the wrong thing to do
right now - adding the time-based component to the AIL flushing
would be a better solution.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-12-10 1:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-09 23:42 [PATCH 2/2] XFS: Mark no-more-exist xfsbufd related sysctl parameters as obsolete Satoru Takeuchi
2012-12-10 1:30 ` Dave Chinner [this message]
2012-12-10 1:58 ` Satoru Takeuchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210013048.GK15784@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=takeuchi_satoru@jp.fujitsu.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox