From: Ben Myers <bpm@sgi.com>
To: Eric Sandeen <esandeen@redhat.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures
Date: Tue, 29 Jan 2013 12:49:18 -0600 [thread overview]
Message-ID: <20130129184918.GG27055@sgi.com> (raw)
In-Reply-To: <FE50BC18-140F-43E6-848A-EE4C9B79C9FC@redhat.com>
Hey,
On Sun, Jan 27, 2013 at 09:41:28PM -0500, Eric Sandeen wrote:
> On Jan 27, 2013, at 8:38 PM, Dave Chinner <david@fromorbit.com> wrote:
>
> > On Sat, Jan 26, 2013 at 04:40:26PM -0600, Eric Sandeen wrote:
> >> This is a merge-to-userspace of kernel commit a0041684
> >> xfs: zero allocation_args on the kernel stack
> >>
> >> When calling xfs_alloc_vextent args.userdata was uninitialized,
> >> and if we had args.type==XFS_ALLOCTYPE_START_BNO, this uninit
> >> structure member got tested, leading to some random allocator
> >> behavior.
> >
> > Got that as part of the kernel-user sync I sent out a couple of
> > weeks back.
> >
> > BTW, perhaps we want to get that sync sorted out before shovelling
> > a bunch of stuff into xfsprogs that will require fixing conflicts in
> > that sync up?
> >
> I have no problem with this going 2nd, I can fix up as needed.
We need to do another userspace release to resolve the backward compatability
issue for Fugazzi and missing source file in xfsprogs for Arkadiusz before
shovelling in that ueber patch. If any of these patches are bug fixes
appropriate for a release within the next week or so, give a heads up.
Thanks,
Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-01-29 18:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 22:40 [PATCH 0/8] xfsprogs: misc small fixes Eric Sandeen
2013-01-26 22:40 ` [PATCH 1/8] libhandle: Guard against string overflow in path_to_fspath() Eric Sandeen
2013-01-26 22:40 ` [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures Eric Sandeen
2013-01-28 0:35 ` Dave Chinner
2013-01-28 2:41 ` Eric Sandeen
2013-01-29 18:49 ` Ben Myers [this message]
2013-01-28 14:21 ` Mark Tinguely
2013-01-26 22:40 ` [PATCH 3/8] libxfs: fix setup_cursor array allocation Eric Sandeen
2013-01-26 22:40 ` [PATCH 4/8] xfs_repair: Fix free of uninit ptr in xfs_acl_valid() error path Eric Sandeen
2013-01-26 22:40 ` [PATCH 5/8] xfs_fsr: guard against path string overflows Eric Sandeen
2013-01-26 22:40 ` [PATCH 6/8] xfs_fsr: check strdup results properly in initallfs() Eric Sandeen
2013-01-26 22:40 ` [PATCH 7/8] xfs_fsr: fix attribute no_change_count logic Eric Sandeen
2013-01-26 22:40 ` [PATCH 8/8] xfs_fsr: remove extraneous close() in fsrallfs() Eric Sandeen
2013-02-20 22:09 ` [PATCH 0/8] xfsprogs: misc small fixes Mark Tinguely
2013-02-21 17:02 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129184918.GG27055@sgi.com \
--to=bpm@sgi.com \
--cc=esandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox