* xfsprogs: fix warning in libxcmd/input.c
@ 2013-02-01 21:36 Ben Myers
2013-02-01 21:43 ` Mark Tinguely
0 siblings, 1 reply; 2+ messages in thread
From: Ben Myers @ 2013-02-01 21:36 UTC (permalink / raw)
To: xfs
Fix an error when building with -Werror=format-security.
input.c: In function 'fetchline':
input.c:91:2: error: format not a string literal and no format arguments [-Werror=format-security]
Signed-off-by: Ben Myers <bpm@sgi.com>
Reported by: Arkadiusz Miśkiewicz <arekm@maven.pl>
Index: xfsprogs/libxcmd/input.c
===================================================================
--- xfsprogs.orig/libxcmd/input.c 2013-02-01 15:29:47.069894522 -0600
+++ xfsprogs/libxcmd/input.c 2013-02-01 15:30:00.845895188 -0600
@@ -88,7 +88,7 @@
if (!line)
return NULL;
- printf(get_prompt());
+ printf("%s", get_prompt());
fflush(stdout);
if (!fgets(line, MAXREADLINESZ, stdin)) {
free(line);
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: xfsprogs: fix warning in libxcmd/input.c
2013-02-01 21:36 xfsprogs: fix warning in libxcmd/input.c Ben Myers
@ 2013-02-01 21:43 ` Mark Tinguely
0 siblings, 0 replies; 2+ messages in thread
From: Mark Tinguely @ 2013-02-01 21:43 UTC (permalink / raw)
To: Ben Myers; +Cc: xfs
On 02/01/13 15:36, Ben Myers wrote:
> Fix an error when building with -Werror=format-security.
>
> input.c: In function 'fetchline':
> input.c:91:2: error: format not a string literal and no format arguments [-Werror=format-security]
>
> Signed-off-by: Ben Myers<bpm@sgi.com>
> Reported by: Arkadiusz Miśkiewicz<arekm@maven.pl>
> Index: xfsprogs/libxcmd/input.c
> ===================================================================
> --- xfsprogs.orig/libxcmd/input.c 2013-02-01 15:29:47.069894522 -0600
> +++ xfsprogs/libxcmd/input.c 2013-02-01 15:30:00.845895188 -0600
> @@ -88,7 +88,7 @@
>
> if (!line)
> return NULL;
> - printf(get_prompt());
> + printf("%s", get_prompt());
> fflush(stdout);
> if (!fgets(line, MAXREADLINESZ, stdin)) {
> free(line);
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-01 21:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-01 21:36 xfsprogs: fix warning in libxcmd/input.c Ben Myers
2013-02-01 21:43 ` Mark Tinguely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox