public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Linda Walsh <xfs@tlinx.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: xfsdump showing system problems -- ?  ideas?
Date: Mon, 4 Feb 2013 10:17:06 +1100	[thread overview]
Message-ID: <20130203231706.GJ2667@dastard> (raw)
In-Reply-To: <510DDE61.6060005@tlinx.org>

On Sat, Feb 02, 2013 at 07:49:53PM -0800, Linda Walsh wrote:
> 
> 
> I was looking through my backup logs and noticed a few of the
> *logs* of the backups having abnormally high size.
> 
> In looking at them, I saw a bunch of messages (last night 3211 occurrences),
> of messages like:
> 
> xfsdump: WARNING: could not get list of root attributes for nondir
> ino 3415547687: Cannot allocate memory (12)
> xfsdump: WARNING: could not get list of secure attributes for nondir
> ino 3415547687: Cannot allocate memory (12)
> xfsdump: WARNING: could not get list of non-root attributes for
> nondir ino 3415547688: Cannot allocate memory (12)
> xfsdump: WARNIN: could not get list of non-root attributes for
> nondir ino 4225270812: Cannot allocate memory (12)
> xfsdump: WARNING: could not get list of root attributes for nondir
> ino 4225270812: Cannot allocate memory (12)
> xfsdump: WARNING: could not get list of secure attributes for nondir
> ino 4225270812: Cannot allocate memory (12)

Was fixed in 3.4:

$ gl -n 1 ad650f5
commit ad650f5b27bc9858360b42aaa0d9204d16115316
Author: Dave Chinner <dchinner@redhat.com>
Date:   Wed Mar 7 04:50:21 2012 +0000

    xfs: fallback to vmalloc for large buffers in xfs_attrmulti_attr_get
    
    xfsdump uses for a large buffer for extended attributes, which has a
    kmalloc'd shadow buffer in the kernel. This can fail after the
    system has been running for some time as it is a high order
    allocation. Add a fallback to vmalloc so that it doesn't require
    contiguous memory and so won't randomly fail while xfsdump is
    running.
    
    Signed-off-by: Dave Chinner <dchinner@redhat.com>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Reviewed-by: Mark Tinguely <tinguely@sgi.com>
    Signed-off-by: Ben Myers <bpm@sgi.com>
$ git describe --contains ad650f5
v3.4-rc1~55^2~11
$

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2013-02-03 23:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-03  3:49 xfsdump showing system problems -- ? ideas? Linda Walsh
2013-02-03  4:53 ` xfsdump -OOM triggering 'soft' kernel panic Linda Walsh
2013-02-03 15:39   ` Stan Hoeppner
2013-02-03 23:17 ` Dave Chinner [this message]
2013-02-04  1:49   ` xfsdump showing system problems -- ? ideas? Linda Walsh
2013-02-04  9:01     ` xfsdump fix tested... level 0's on all partitions: no problems Linda Walsh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130203231706.GJ2667@dastard \
    --to=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    --cc=xfs@tlinx.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox