Re: [test] comments removed

From: Hugo Mills <hugo@carfax.org.uk>
To: Hemanth Kumar <hemanthkumar51@gmail.com>
Cc: sandeen@redhat.com, sensille@gmx.net, ganeshkumar14@gmail.com,
	praneethu.u@gmail.com, xfs@oss.sgi.com, bo.li.liu@oracle.com,
	skjmca51@gmail.com, chetahan.casey@gmail.com,
	kirantpatil@gmail.com, linux-btrfs@vger.kernel.org
Subject: Re: [test] comments removed
Date: Fri, 15 Feb 2013 08:47:33 +0000	[thread overview]
Message-ID: <20130215084733.GH28997@carfax.org.uk> (raw)
In-Reply-To: <1360909755-2966-1-git-send-email-hemanthkumar51@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 2855 bytes --]

On Fri, Feb 15, 2013 at 11:59:15AM +0530, Hemanth Kumar wrote:

   No description of what the patch does. You should probably also put
[btrfs-progs] in the subject line, if you're patching against
btrfs-progs (and in that case, you probably don't need to cc the xfs
people).

   More comments below.

   Hugo.

> Signed-off-by: Hemanth Kumar <hemanthkumar51@gmail.com>
> ---
>  0001-heirarchical-quotas-test-case.patch | 44 ++++++++++++++++++++++++++++++++
        hierarchical

>  hquotas.sh                               |  2 --
>  2 files changed, 44 insertions(+), 2 deletions(-)
>  create mode 100644 0001-heirarchical-quotas-test-case.patch
> 
> diff --git a/0001-heirarchical-quotas-test-case.patch b/0001-heirarchical-quotas-test-case.patch

    And here

> new file mode 100644
> index 0000000..c6577e0
> --- /dev/null
> +++ b/0001-heirarchical-quotas-test-case.patch

    And here

> @@ -0,0 +1,44 @@
> +From 9f49a870eab70ae37028f937331f9ec1b67dadb1 Mon Sep 17 00:00:00 2001
> +From: Hemanth Kumar <hemanthkumar51@gmail.com>
> +Date: Fri, 15 Feb 2013 11:21:03 +0530
> +Subject: [test] heirarchical quotas test case
> +
> +
> +Signed-off-by: Hemanth Kumar <hemanthkumar51@gmail.com>

   You're sending a patch file that creates a patch file? This is wrong.

> +---
> + hquotas.sh | 8 ++++----
> + 1 file changed, 4 insertions(+), 4 deletions(-)
> +
> +diff --git a/hquotas.sh b/hquotas.sh
> +index 2eaae01..a870d4a 100644
> +--- a/hquotas.sh
> ++++ b/hquotas.sh
> +@@ -1,7 +1,5 @@
> + #! /bin/bash
> +-# btrfs quotas test case
> +-#owner=hemanthkumar51@gamil.com ganeshkumr14@gmail.com
> +-
> ++# btrfs hierarchical quotas test case
> + #here=`pwd`
> + #tmp=/sample
> + status=1
> +@@ -11,6 +9,8 @@ cleanup()
> + 	btrfs subvolume delete $TEST_DIR/vol1/vol2/vol3
> + 	btrfs subvolume delete $TEST_DIR/vol1/vol2
> + 	btrfs subvolume delete $TEST_DIR/vol1
> ++	btrfs quota disable $TEST_DIR
> ++	echo"quota disabled"
> + }
> + 
> + #trap "_cleanup ; exit \$status" 0 1 2 3 15
> +@@ -25,6 +25,6 @@ btrfs qgroup limit 3m $TEST_DIR/vol1/vol2
> + btrfs qgroup limit 1m $TEST_DIR/vol1/vol2/vol3
> + dd if=$TEST_DEV of=$TEST_DIR/vol1/vol2/vol3/file3 bs=2M count=1
> + dd if=$TEST_DEV of=$TEST_DIR/vol1/vol2/file2 bs=1M count=1
> +-dd if=$TEST_DEV of=$TEST_DIR/vol1/file1 bs=5M count=1
> ++dd if=$TEST_DEV of=$TEST_DIR/vol1/file1 bs=4M count=1
> + cleanup
> + exit
> +-- 
> +1.8.1.2
> +
> diff --git a/hquotas.sh b/hquotas.sh
> index a870d4a..672b6d1 100644
> --- a/hquotas.sh
> +++ b/hquotas.sh
> @@ -1,7 +1,5 @@
>  #! /bin/bash
>  # btrfs hierarchical quotas test case
> -#here=`pwd`
> -#tmp=/sample
>  status=1
>  
>  cleanup()

-- 
=== Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk ===
  PGP key: 515C238D from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
                    --- Beware geeks bearing GIFs ---                    

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs