[PATCH] xfstests 100: do not use scratch

[PATCH] xfstests 100: do not use scratch

[Lukas Czerner]

Test #100 does not use scratch device at all but it still
_require_scratch and _check_scratch_fs. This might also be a problem if
the test before this one failed and corrupted scratch partition.

Remove the _require_scratch() and _check_scratch_fs() from the test.

Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
 100 |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/100 b/100
index f3504ce..ad61823 100755
--- a/100
+++ b/100
@@ -69,7 +69,6 @@ _populate_fs -n $NDIRS -f $NFILES -d $DEPTH -r $POPULATED_DIR -s $SIZE >>$here/$
 tar -cvf $TEMP_DIR/$TAR_FILE $POPULATED_DIR >>$here/$seq.full 2>&1
 
 # create f/s
-_require_scratch
 _setup_testdir
 
 # untar on f/s
@@ -84,7 +83,6 @@ diff -qr $POPULATED_DIR ${testdir}${POPULATED_DIR}
 
 cd /
 _cleanup_testdir
-_check_scratch_fs
 
 status=0
 exit
-- 
1.7.7.6

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests 100: do not use scratch

[Dave Chinner]

On Mon, Feb 18, 2013 at 08:51:51AM +0100, Lukas Czerner wrote:
> Test #100 does not use scratch device at all but it still
> _require_scratch and _check_scratch_fs. This might also be a problem if
> the test before this one failed and corrupted scratch partition.
> 
> Remove the _require_scratch() and _check_scratch_fs() from the test.

Actaully, I think it should be using scratch - have  a look at where
TEMP_DIR is located. Yeah, it's /tmp, not the scratch device.

i.e. it should be using the TEST_DIR rather than tmp for building
the tarball, and scratch for restoring it....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs