From: Dave Chinner <david@fromorbit.com>
To: Ben Myers <bpm@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/9] xfs: metadata CRCs, kernel, first batch
Date: Sat, 23 Feb 2013 10:12:17 +1100 [thread overview]
Message-ID: <20130222231217.GA26081@dastard> (raw)
In-Reply-To: <20130222151931.GU22182@sgi.com>
On Fri, Feb 22, 2013 at 09:19:31AM -0600, Ben Myers wrote:
> Dave,
>
> Dunno if you've seen this one:
>
> BUG: unable to handle kernel NULL pointer dereference at 00000000000000d0
> [601393.932814] IP: [<ffffffffa06e5dcc>] xfs_dquot_buf_verify+0x1c/0xb0 [xfs]
.....
> [601393.932814] Call Trace:
> [601393.932814] [<ffffffffa06e7b89>] xfs_dquot_buf_write_verify+0x29/0x90 [xfs]
> [601393.932814] [<ffffffff811db523>] ? blk_finish_plug+0x13/0x50
> [601393.932814] [<ffffffffa0676058>] _xfs_buf_ioapply+0x68/0x360 [xfs]
> [601393.932814] [<ffffffff810696b0>] ? try_to_wake_up+0x2b0/0x2b0
> [601393.932814] [<ffffffffa0677b23>] xfs_buf_iorequest+0x53/0x70 [xfs]
> [601393.932814] [<ffffffffa0677e25>] xfs_bdstrat_cb+0x35/0x60 [xfs]
> [601393.932814] [<ffffffffa0677f98>] __xfs_buf_delwri_submit+0x148/0x1c0 [xfs]
> [601393.932814] [<ffffffffa067803b>] xfs_buf_delwri_submit+0x2b/0x90 [xfs]
> [601393.932814] [<ffffffffa06d1de1>] xlog_recover_commit_trans+0x111/0x120 [xfs]
> [601393.932814] [<ffffffffa06d1ff1>] xlog_recover_process_data+0x201/0x2b0 [xfs]
> [601393.932814] [<ffffffffa06d257c>] xlog_do_recovery_pass+0x4dc/0x760 [xfs]
> [601393.932814] [<ffffffff8103e3b5>] ? console_unlock+0x265/0x3a0
> [601393.932814] [<ffffffffa06d289c>] xlog_do_log_recovery+0x9c/0x110 [xfs]
> [601393.932814] [<ffffffffa06d2933>] xlog_do_recover+0x23/0x1e0 [xfs]
This is mentioned in the patch zero description:
"This series makes is through to 001-092 in xfstests - there is a
problem in the dquot verifier that causes log recovery of dquot
buffers to follow a NULL pointer."
Basically, mp->m_quotainfo is not initialised until after log
recovery occurs, so this has to be detected in the verify/crc
routines otherwise it goes splat like above. My current patch series
has this fixed.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-02-22 23:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1358774760-21841-1-git-send-email-david@fromorbit.com>
[not found] ` <1358774760-21841-2-git-send-email-david@fromorbit.com>
2013-02-14 21:25 ` [PATCH 1/9] xfs: take inode version into account in XFS_LITINO Ben Myers
[not found] ` <1358774760-21841-3-git-send-email-david@fromorbit.com>
2013-02-15 21:20 ` [PATCH 2/9] xfs: add support for large btree blocks Ben Myers
2013-02-22 1:34 ` Dave Chinner
2013-02-23 2:27 ` Dave Chinner
2013-03-04 16:31 ` Ben Myers
[not found] ` <1358774760-21841-4-git-send-email-david@fromorbit.com>
2013-02-21 22:53 ` [PATCH 3/9] xfs: add CRC checks to the AGF Ben Myers
2013-02-22 1:41 ` Dave Chinner
2013-02-22 15:19 ` [PATCH 0/9] xfs: metadata CRCs, kernel, first batch Ben Myers
2013-02-22 23:12 ` Dave Chinner [this message]
2013-02-22 23:50 ` Ben Myers
2013-02-23 2:38 ` Dave Chinner
2013-03-04 16:33 ` Ben Myers
[not found] ` <1358774760-21841-5-git-send-email-david@fromorbit.com>
2013-02-27 22:37 ` [PATCH 4/9] xfs: add CRC checks to the AGFL Ben Myers
2013-02-27 23:20 ` Dave Chinner
2013-02-27 23:31 ` Dave Chinner
2013-02-27 23:35 ` Ben Myers
2013-02-27 23:32 ` Ben Myers
[not found] ` <1358774760-21841-6-git-send-email-david@fromorbit.com>
2013-03-04 17:40 ` [PATCH 5/9] xfs: add CRC checks to the AGI Ben Myers
2013-03-04 17:41 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130222231217.GA26081@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox