From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id C33DA7F50 for ; Fri, 22 Feb 2013 17:12:24 -0600 (CST) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id 0588CAC005 for ; Fri, 22 Feb 2013 15:12:20 -0800 (PST) Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id 6MDNQpqboErZFCld for ; Fri, 22 Feb 2013 15:12:19 -0800 (PST) Date: Sat, 23 Feb 2013 10:12:17 +1100 From: Dave Chinner Subject: Re: [PATCH 0/9] xfs: metadata CRCs, kernel, first batch Message-ID: <20130222231217.GA26081@dastard> References: <1358774760-21841-1-git-send-email-david@fromorbit.com> <20130222151931.GU22182@sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130222151931.GU22182@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Ben Myers Cc: xfs@oss.sgi.com On Fri, Feb 22, 2013 at 09:19:31AM -0600, Ben Myers wrote: > Dave, > > Dunno if you've seen this one: > > BUG: unable to handle kernel NULL pointer dereference at 00000000000000d0 > [601393.932814] IP: [] xfs_dquot_buf_verify+0x1c/0xb0 [xfs] ..... > [601393.932814] Call Trace: > [601393.932814] [] xfs_dquot_buf_write_verify+0x29/0x90 [xfs] > [601393.932814] [] ? blk_finish_plug+0x13/0x50 > [601393.932814] [] _xfs_buf_ioapply+0x68/0x360 [xfs] > [601393.932814] [] ? try_to_wake_up+0x2b0/0x2b0 > [601393.932814] [] xfs_buf_iorequest+0x53/0x70 [xfs] > [601393.932814] [] xfs_bdstrat_cb+0x35/0x60 [xfs] > [601393.932814] [] __xfs_buf_delwri_submit+0x148/0x1c0 [xfs] > [601393.932814] [] xfs_buf_delwri_submit+0x2b/0x90 [xfs] > [601393.932814] [] xlog_recover_commit_trans+0x111/0x120 [xfs] > [601393.932814] [] xlog_recover_process_data+0x201/0x2b0 [xfs] > [601393.932814] [] xlog_do_recovery_pass+0x4dc/0x760 [xfs] > [601393.932814] [] ? console_unlock+0x265/0x3a0 > [601393.932814] [] xlog_do_log_recovery+0x9c/0x110 [xfs] > [601393.932814] [] xlog_do_recover+0x23/0x1e0 [xfs] This is mentioned in the patch zero description: "This series makes is through to 001-092 in xfstests - there is a problem in the dquot verifier that causes log recovery of dquot buffers to follow a NULL pointer." Basically, mp->m_quotainfo is not initialised until after log recovery occurs, so this has to be detected in the verify/crc routines otherwise it goes splat like above. My current patch series has this fixed. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs