From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id BFBFE7F50 for ; Fri, 22 Feb 2013 18:56:48 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 4142DAC004 for ; Fri, 22 Feb 2013 16:56:48 -0800 (PST) Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id bJ7Hs2T9B3N5ivdO for ; Fri, 22 Feb 2013 16:56:47 -0800 (PST) Date: Sat, 23 Feb 2013 11:56:45 +1100 From: Dave Chinner Subject: Re: [PATCH] xfs: fix potential infinite loop in xfs_iomap_prealloc_size() Message-ID: <20130223005645.GD26081@dastard> References: <1361557976-54981-1-git-send-email-bfoster@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1361557976-54981-1-git-send-email-bfoster@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Brian Foster Cc: xfs@oss.sgi.com On Fri, Feb 22, 2013 at 01:32:56PM -0500, Brian Foster wrote: > If freesp == 0, we could end up in an infinite loop while squashing > the preallocation. Break the loop when we've killed the prealloc > entirely. > > Signed-off-by: Brian Foster Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs