From: Dave Chinner <david@fromorbit.com>
To: Ben Myers <bpm@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/9] xfs: metadata CRCs, kernel, first batch
Date: Sat, 23 Feb 2013 13:38:18 +1100 [thread overview]
Message-ID: <20130223023818.GJ26081@dastard> (raw)
In-Reply-To: <20130222235029.GA30652@sgi.com>
On Fri, Feb 22, 2013 at 05:50:29PM -0600, Ben Myers wrote:
> On Sat, Feb 23, 2013 at 10:12:17AM +1100, Dave Chinner wrote:
> > On Fri, Feb 22, 2013 at 09:19:31AM -0600, Ben Myers wrote:
> > This is mentioned in the patch zero description:
> >
> > "This series makes is through to 001-092 in xfstests - there is a
> > problem in the dquot verifier that causes log recovery of dquot
> > buffers to follow a NULL pointer."
> >
> > Basically, mp->m_quotainfo is not initialised until after log
> > recovery occurs, so this has to be detected in the verify/crc
> > routines otherwise it goes splat like above. My current patch series
> > has this fixed.
>
> Cool. Sorry for the extra noise.
No, that's fine. It tells me that you're actaully looking at the
code and seeing what it does ;)
I'm close to having a new version of the kernel patchset out. I've
just got to finish debugging the attribute changes I've made and
move the superblock support patch to the end of the series and I'll
post it out.
All I'm aiming for with the next version of the patch set is that
existing filesystems (i.e. no CRCs) are regression free. I've
actaully done very little CRC enabled testing while doing all the
directory and attribute code changes, mainly because I can't test
them properly until the userspace support is there. However, the
patch set up to the final patch (i.e. everything but the attribute
changes) seems to work just fine with the existing toolchain and
xfstests.
Put simply, my focus for testing the patch set is currently "no
regressions for existing users", not "CRCs work perfectly".
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-02-23 2:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1358774760-21841-1-git-send-email-david@fromorbit.com>
[not found] ` <1358774760-21841-2-git-send-email-david@fromorbit.com>
2013-02-14 21:25 ` [PATCH 1/9] xfs: take inode version into account in XFS_LITINO Ben Myers
[not found] ` <1358774760-21841-3-git-send-email-david@fromorbit.com>
2013-02-15 21:20 ` [PATCH 2/9] xfs: add support for large btree blocks Ben Myers
2013-02-22 1:34 ` Dave Chinner
2013-02-23 2:27 ` Dave Chinner
2013-03-04 16:31 ` Ben Myers
[not found] ` <1358774760-21841-4-git-send-email-david@fromorbit.com>
2013-02-21 22:53 ` [PATCH 3/9] xfs: add CRC checks to the AGF Ben Myers
2013-02-22 1:41 ` Dave Chinner
2013-02-22 15:19 ` [PATCH 0/9] xfs: metadata CRCs, kernel, first batch Ben Myers
2013-02-22 23:12 ` Dave Chinner
2013-02-22 23:50 ` Ben Myers
2013-02-23 2:38 ` Dave Chinner [this message]
2013-03-04 16:33 ` Ben Myers
[not found] ` <1358774760-21841-5-git-send-email-david@fromorbit.com>
2013-02-27 22:37 ` [PATCH 4/9] xfs: add CRC checks to the AGFL Ben Myers
2013-02-27 23:20 ` Dave Chinner
2013-02-27 23:31 ` Dave Chinner
2013-02-27 23:35 ` Ben Myers
2013-02-27 23:32 ` Ben Myers
[not found] ` <1358774760-21841-6-git-send-email-david@fromorbit.com>
2013-03-04 17:40 ` [PATCH 5/9] xfs: add CRC checks to the AGI Ben Myers
2013-03-04 17:41 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130223023818.GJ26081@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox