From: Dave Chinner <david@fromorbit.com>
To: "Cheung, Norman" <Norman.Cheung@kla-tencor.com>
Cc: "'linux-xfs@oss.sgi.com'" <linux-xfs@oss.sgi.com>
Subject: Re: Hung in D state during fclose
Date: Wed, 27 Feb 2013 07:31:35 +1100 [thread overview]
Message-ID: <20130226203135.GS5551@dastard> (raw)
In-Reply-To: <3542214BE3A3EF419F236DFE0F878BC9055A4A@BL2PRD0310MB374.namprd03.prod.outlook.com>
On Tue, Feb 26, 2013 at 07:41:42PM +0000, Cheung, Norman wrote:
> I'd been checking all the XFS patches if any might relate to my situation and came across this
> http://article.gmane.org/gmane.comp.file-systems.xfs.general/40349/
>
> From: Christoph Hellwig <hch <at> infradead.org>
> Subject: [PATCH, RFC] writeback: avoid redirtying when ->write_inode failed to clear I_DIRTY
> Newsgroups: gmane.comp.file-systems.xfs.general
> Date: 2011-08-27 06:14:09 GMT (1 year, 26 weeks, 1 day, 13 hours and 17 minutes ago)
> Right now ->write_inode has no way to safely return a EAGAIN without explicitly
> redirtying the inode, as we would lose the dirty state otherwise. Most
> filesystems get this wrong, but XFS makes heavy use of it to avoid blocking
> the flusher thread when ->write_inode hits contentended inode locks. A
> contended ilock is something XFS can hit very easibly when extending files, as
> the data I/O completion handler takes the lock to update the size, and the
> ->write_inode call can race with it fairly easily if writing enough data
> in one go so that the completion for the first write come in just before
> we call ->write_inode.
>
> Change the handling of this case to use requeue_io for a quick retry instead
> of redirty_tail, which keeps moving out the dirtied_when data and thus keeps
> delaying the writeout more and more with every failed attempt to get the lock.
>
> I wonder if this would have caused my application waiting for xfs_ilock. I checked
> that this patch is not in my kernel source (SUSE 11 SP2, Rel 3.0.13-0.27)
I have no idea whether it will help or not, because SuSE (like Red
Hat) ship a heavily patched kernel and so it's rather hard for
anyone here to triage and diagnose problems like this. Further, even
if we can find a potential cause, we still can't fix it for you.
Hence perhaps you are best advised to talk to your SuSE support
contact at this point?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-02-26 20:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 6:17 Hung in D state during fclose Norman Cheung
2013-02-12 6:55 ` Dave Chinner
2013-02-12 7:01 ` Cheung, Norman
2013-02-12 10:20 ` Dave Chinner
2013-02-12 16:39 ` Cheung, Norman
2013-02-12 20:22 ` Dave Chinner
2013-02-12 21:06 ` Cheung, Norman
2013-02-12 22:21 ` Dave Chinner
2013-02-13 0:12 ` Cheung, Norman
2013-02-13 5:15 ` Dave Chinner
2013-02-14 4:53 ` Cheung, Norman
2013-02-26 19:41 ` Cheung, Norman
2013-02-26 20:31 ` Dave Chinner [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-11 23:36 Cheung, Norman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130226203135.GS5551@dastard \
--to=david@fromorbit.com \
--cc=Norman.Cheung@kla-tencor.com \
--cc=linux-xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox