From: Ben Myers <bpm@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/9] xfs: add CRC checks to the AGFL
Date: Wed, 27 Feb 2013 17:35:37 -0600 [thread overview]
Message-ID: <20130227233537.GB22182@sgi.com> (raw)
In-Reply-To: <20130227233155.GF5551@dastard>
Dave,
On Thu, Feb 28, 2013 at 10:31:55AM +1100, Dave Chinner wrote:
> On Thu, Feb 28, 2013 at 10:20:45AM +1100, Dave Chinner wrote:
> > On Wed, Feb 27, 2013 at 04:37:50PM -0600, Ben Myers wrote:
> > > Hi Dave,
> ....
> > > > + case XFS_BLF_AGFL_BUF:
> > > > + if (*(__be32 *)bp->b_addr != cpu_to_be32(XFS_AGFL_MAGIC)) {
> > > > + xfs_warn(mp, "Bad AGFL block magic!");
> > > > + ASSERT(0);
> > > > + }
> > > > + bp->b_ops = &xfs_agfl_buf_ops;
> > > > + break;
> > >
> > > Your changes for v2 in this section look good.
> >
> > Actually, the above hunk is broken. The magic number should only be
> > checked for CRC enabled filesystems. My current code has this check,
> > though I thought I fixed that long before I reposted this series...
>
> I just realised you're commenting on the original version of the
> patch series, no the new version I posted a couple of days ago. It
> is fixed in that version of the patch, so I'm not going totally
> crazy (yet!)....
Yep. The new rev looks good.
> Can you switch over to the newer version of the patch set?
Will do.
-Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-02-27 23:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1358774760-21841-1-git-send-email-david@fromorbit.com>
[not found] ` <1358774760-21841-2-git-send-email-david@fromorbit.com>
2013-02-14 21:25 ` [PATCH 1/9] xfs: take inode version into account in XFS_LITINO Ben Myers
[not found] ` <1358774760-21841-3-git-send-email-david@fromorbit.com>
2013-02-15 21:20 ` [PATCH 2/9] xfs: add support for large btree blocks Ben Myers
2013-02-22 1:34 ` Dave Chinner
2013-02-23 2:27 ` Dave Chinner
2013-03-04 16:31 ` Ben Myers
[not found] ` <1358774760-21841-4-git-send-email-david@fromorbit.com>
2013-02-21 22:53 ` [PATCH 3/9] xfs: add CRC checks to the AGF Ben Myers
2013-02-22 1:41 ` Dave Chinner
2013-02-22 15:19 ` [PATCH 0/9] xfs: metadata CRCs, kernel, first batch Ben Myers
2013-02-22 23:12 ` Dave Chinner
2013-02-22 23:50 ` Ben Myers
2013-02-23 2:38 ` Dave Chinner
2013-03-04 16:33 ` Ben Myers
[not found] ` <1358774760-21841-5-git-send-email-david@fromorbit.com>
2013-02-27 22:37 ` [PATCH 4/9] xfs: add CRC checks to the AGFL Ben Myers
2013-02-27 23:20 ` Dave Chinner
2013-02-27 23:31 ` Dave Chinner
2013-02-27 23:35 ` Ben Myers [this message]
2013-02-27 23:32 ` Ben Myers
[not found] ` <1358774760-21841-6-git-send-email-david@fromorbit.com>
2013-03-04 17:40 ` [PATCH 5/9] xfs: add CRC checks to the AGI Ben Myers
2013-03-04 17:41 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130227233537.GB22182@sgi.com \
--to=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox