From: Dave Chinner <david@fromorbit.com>
To: CAI Qian <caiqian@redhat.com>
Cc: Mark Tinguely <tinguely@sgi.com>,
Brian Foster <bfoster@redhat.com>,
stable@vger.kernel.org, xfs@oss.sgi.com, Ben Myers <bpm@sgi.com>,
Dave Chinner <dchinner@redhat.com>
Subject: Re: request for stable inclusion
Date: Tue, 5 Mar 2013 09:11:00 +1100 [thread overview]
Message-ID: <20130304221100.GL26081@dastard> (raw)
In-Reply-To: <1879117295.8593844.1362387154930.JavaMail.root@redhat.com>
On Mon, Mar 04, 2013 at 03:52:34AM -0500, CAI Qian wrote:
> This is to request to apply the below commit for the stable releases
> in order to fix a regression introduced by 055388a (xfs: dynamic
> speculative EOF preallocation) that caused fsync() took long time during
> the sparse file testing.
>
> For stable-3.4 and stable-3.8, it can be applied as it is. For stable-3.0,
> please see the below patch which fixed the context and used xfs_bmapi()
> instead of xfs_bmapi_read() which yet in the tree. Also tested on the
> stable-3.0 to confirmed the original fsync() slowness regression is now
> gone. Please review and ACK.
I've already said no to -stable in another discussion thread, and
that discussion has not yet played out. please do not try to preempt
any discussion by sending patches to @stable before it is even
decided if it is something we *need* to fix in 2 year old kernels.
Yes, you have input into the discussion, but please do not take it
upon yourself to determine what should be backported to -stable and
what shouldn't be - that is for the subsystem maintainers to decide.
FWIW, is your memory so short that you don't remember what happened
a couple of weeks ago with the last XFS bugfix backport you
requested directly to @stable and was accepted based on "it applies
and builds, so it's OK?" i.e. without proper review, discussion or
testing?
That's right - it caused a major functional regression and that
wasted a heap of time for quite a few people in sorting it out.
So right now this request gets a big, fat, loud NACK from me while
the aforementioned discussion takes place.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-04 22:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <426368976.8591643.1362386550488.JavaMail.root@redhat.com>
2013-03-04 8:52 ` request for stable inclusion CAI Qian
2013-03-04 22:11 ` Dave Chinner [this message]
2013-03-05 21:32 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130304221100.GL26081@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=bpm@sgi.com \
--cc=caiqian@redhat.com \
--cc=dchinner@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox