From: Eric Whitney <enwlinux@gmail.com>
To: xfs@oss.sgi.com
Cc: sandeen@redhat.com
Subject: [PATCH V3] xfstests: don't remove trailing zeros from integers
Date: Tue, 5 Mar 2013 14:17:48 -0500 [thread overview]
Message-ID: <20130305191748.GB3930@wallace> (raw)
_within_tolerance strips trailing zeros from the min and max range
values it outputs. This leads to damage if the min or max value is
an integer containing trailing zeros rather than a real number with
a fractional part containing trailing zeros. Xfstest 289 can exhibit
this problem when its input is out of range. Modify the code so it
will only remove trailing zeros found after a decimal point.
V1->V2: Remove decimal points not followed by digits
V2->V3: Per Dave Chinner, simplify by using multiple sed expressions
Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
common.filter | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/common.filter b/common.filter
index 9e4c90c..c854a98 100644
--- a/common.filter
+++ b/common.filter
@@ -106,8 +106,10 @@ EOF
# fix up min, max precision for output
# can vary for 5.3, 6.2
- _min=`echo $_min | sed -e 's/0*$//'` # get rid of trailling zeroes
- _max=`echo $_max | sed -e 's/0*$//'` # get rid of trailling zeroes
+
+ # remove any trailing zeroes from min, max if they have fractional parts
+ _min=`echo $_min | sed -e '/\./s/0*$//' -e 's/\.$//'`
+ _max=`echo $_max | sed -e '/\./s/0*$//' -e 's/\.$//'`
if [ $_in_range -eq 1 ]
then
--
1.7.10.4
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2013-03-05 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 19:17 Eric Whitney [this message]
2013-03-05 19:30 ` [PATCH V3] xfstests: don't remove trailing zeros from integers Eric Sandeen
2013-03-05 19:49 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305191748.GB3930@wallace \
--to=enwlinux@gmail.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox