From: Ben Myers <bpm@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 07/16] xfs: add CRC checks for quota blocks
Date: Tue, 5 Mar 2013 14:36:15 -0600 [thread overview]
Message-ID: <20130305203615.GK22182@sgi.com> (raw)
In-Reply-To: <1361755901-12453-8-git-send-email-david@fromorbit.com>
Hi Dave,
On Mon, Feb 25, 2013 at 12:31:32PM +1100, Dave Chinner wrote:
> From: Christoph Hellwig <hch@lst.de>
>
> Use the reserved space in struct xfs_dqblk to store a UUID and a crc
> for the quota blocks.
>
> [dchinner@redhat.com] Add a LSN field and update for current verifier
> infrastructure.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Been over this and it looks fine.
> @@ -897,6 +910,10 @@ xfs_qm_dqiter_bufs(
> if (error)
> break;
>
> + /*
> + * XXX(hch): need to figure out if it makes sense to validate
> + * the CRC here.
> + */
What's you're opinion on this?
-Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-05 20:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 1:31 [PATCH 00/16] xfs: metadata CRCs, second batch Dave Chinner
2013-02-25 1:31 ` [PATCH 01/16] xfs: rearrange some code in xfs_bmap for better locality Dave Chinner
2013-02-25 14:44 ` Mark Tinguely
2013-03-07 18:48 ` Ben Myers
2013-02-25 1:31 ` [PATCH 02/16] xfs: take inode version into account in XFS_LITINO Dave Chinner
2013-02-25 1:31 ` [PATCH 03/16] xfs: add support for large btree blocks Dave Chinner
2013-02-25 1:31 ` [PATCH 04/16] xfs: add CRC checks to the AGF Dave Chinner
2013-02-25 1:31 ` [PATCH 05/16] xfs: add CRC checks to the AGFL Dave Chinner
2013-03-01 23:56 ` Ben Myers
2013-02-25 1:31 ` [PATCH 06/16] xfs: add CRC checks to the AGI Dave Chinner
2013-02-25 1:31 ` [PATCH 07/16] xfs: add CRC checks for quota blocks Dave Chinner
2013-03-05 20:36 ` Ben Myers [this message]
2013-03-05 22:49 ` Dave Chinner
2013-02-25 1:31 ` [PATCH 08/16] xfs: add version 3 inode format with CRCs Dave Chinner
2013-02-25 1:31 ` [PATCH 09/16] xfs: add CRC checks to remote symlinks Dave Chinner
2013-02-27 23:35 ` Dave Chinner
2013-02-25 1:31 ` [PATCH 10/16] xfs: add CRC checks to block format directory blocks Dave Chinner
2013-02-25 1:31 ` [PATCH 11/16] xfs: add CRC checking to dir2 free blocks Dave Chinner
2013-02-25 1:31 ` [PATCH 12/16] xfs: add CRC checking to dir2 data blocks Dave Chinner
2013-02-25 1:31 ` [PATCH 13/16] xfs: add CRC checking to dir2 leaf blocks Dave Chinner
2013-02-25 1:31 ` [PATCH 14/16] xfs: add CRCs to dir2/da node blocks Dave Chinner
2013-02-25 1:31 ` [PATCH 15/16] xfs: add CRCs to attr leaf blocks Dave Chinner
2013-02-25 1:31 ` [PATCH 16/16] xfs: add CRC checks to the superblock Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305203615.GK22182@sgi.com \
--to=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox