From: Dave Chinner <david@fromorbit.com>
To: dsterba@suse.cz, Wang Sheng-Hui <shhuiw@gmail.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests 273: fix a typo
Date: Thu, 7 Mar 2013 14:38:49 +1100 [thread overview]
Message-ID: <20130307033849.GB6369@dastard> (raw)
In-Reply-To: <20130306232222.GF21081@twin.jikos.cz>
On Thu, Mar 07, 2013 at 12:22:22AM +0100, David Sterba wrote:
> On Wed, Feb 27, 2013 at 02:47:54PM +0800, Wang Sheng-Hui wrote:
> > Make the porter log cp failure into $seq.full by appending, not overwriting,
> > which can help debug.
> >
> > Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> > ---
> > 273 | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/273 b/273
> > index 67f3d6b..639e280 100755
> > --- a/273
> > +++ b/273
> > @@ -92,7 +92,7 @@ _porter()
> > exit
> > fi
> >
> > - cp -r $SCRATCH_MNT/origin $SCRATCH_MNT/sub_$_suffix >$seq.full 2>&1
> > + cp -r $SCRATCH_MNT/origin $SCRATCH_MNT/sub_$_suffix >>$seq.full 2>&1
>
> This gives me
>
> 273 154s ... [20:05:00] [20:05:01] - output mismatch (see 273.out.bad)
> --- 273.out 2011-11-11 15:13:46.000000000 +0100
> +++ 273.out.bad 2013-03-06 20:05:01.000000000 +0100
> @@ -1,4 +1,4 @@
> QA output created by 273
> -------------------------------
> -start the workload
> -------------------------------
> +./273: line 95: syntax error near unexpected token `&'
> +./273: line 95: ` cp -r $SCRATCH_MNT/origin $SCRATCH_MNT/sub_$_suffix >$seq.full 2>>&1'
> +umount: /dev/sda9: not mounted
that seems rather strange. The patch does this:
....sub_$_suffix >>$seq.full 2>&1
and the error output you see is
....sub_$_suffix >$seq.full 2>>&1
So it doesn't look lie you are running with the change that is
actually in the patch...
> ...
> (Run 'diff -u 273.out 273.out.bad' to see the entire diff)
> ---
>
> The script calls /bin/bash, my version says
> GNU bash, version 4.1.10(1)-release
Wroks fine here, with:
GNU bash, version 4.2.37(1)-release
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-07 3:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 6:47 [PATCH] xfstests 273: fix a typo Wang Sheng-Hui
2013-02-27 23:05 ` Dave Chinner
2013-03-06 23:22 ` David Sterba
2013-03-07 3:38 ` Dave Chinner [this message]
2013-03-07 11:06 ` David Sterba
2013-03-07 11:22 ` David Sterba
2013-03-07 22:48 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130307033849.GB6369@dastard \
--to=david@fromorbit.com \
--cc=dsterba@suse.cz \
--cc=shhuiw@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox