public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs: fix xfs_iomap_eof_prealloc_initial_size type
       [not found] <20130224190436.906161932@sgi.com>
@ 2013-02-24 19:04 ` Mark Tinguely
  2013-02-24 23:37   ` Dave Chinner
  2013-03-07 18:45   ` Ben Myers
  0 siblings, 2 replies; 3+ messages in thread
From: Mark Tinguely @ 2013-02-24 19:04 UTC (permalink / raw)
  To: xfs

[-- Attachment #1: xfs-fix-xfs_iomap_eof_prealloc_initial_size-type.patch --]
[-- Type: text/plain, Size: 852 bytes --]

Fix the return type of xfs_iomap_eof_prealloc_initial_size() to
xfs_fsblock_t to reflect the fact that the return value may be an
unsigned 64 bits if XFS_BIG_BLKNOS is defined.

Signed-off-by: Mark Tinguely <tinguely@sgi.com>
---
 fs/xfs/xfs_iomap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/fs/xfs/xfs_iomap.c
===================================================================
--- a/fs/xfs/xfs_iomap.c
+++ b/fs/xfs/xfs_iomap.c
@@ -325,7 +325,7 @@ xfs_iomap_eof_want_preallocate(
  * rather than falling short due to things like stripe unit/width alignment of
  * real extents.
  */
-STATIC int
+STATIC xfs_fsblock_t
 xfs_iomap_eof_prealloc_initial_size(
 	struct xfs_mount	*mp,
 	struct xfs_inode	*ip,


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfs: fix xfs_iomap_eof_prealloc_initial_size type
  2013-02-24 19:04 ` [PATCH] xfs: fix xfs_iomap_eof_prealloc_initial_size type Mark Tinguely
@ 2013-02-24 23:37   ` Dave Chinner
  2013-03-07 18:45   ` Ben Myers
  1 sibling, 0 replies; 3+ messages in thread
From: Dave Chinner @ 2013-02-24 23:37 UTC (permalink / raw)
  To: Mark Tinguely; +Cc: xfs

On Sun, Feb 24, 2013 at 01:04:37PM -0600, Mark Tinguely wrote:
> Fix the return type of xfs_iomap_eof_prealloc_initial_size() to
> xfs_fsblock_t to reflect the fact that the return value may be an
> unsigned 64 bits if XFS_BIG_BLKNOS is defined.
> 
> Signed-off-by: Mark Tinguely <tinguely@sgi.com>

Good Find.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfs: fix xfs_iomap_eof_prealloc_initial_size type
  2013-02-24 19:04 ` [PATCH] xfs: fix xfs_iomap_eof_prealloc_initial_size type Mark Tinguely
  2013-02-24 23:37   ` Dave Chinner
@ 2013-03-07 18:45   ` Ben Myers
  1 sibling, 0 replies; 3+ messages in thread
From: Ben Myers @ 2013-03-07 18:45 UTC (permalink / raw)
  To: Mark Tinguely; +Cc: xfs

On Sun, Feb 24, 2013 at 01:04:37PM -0600, Mark Tinguely wrote:
> Fix the return type of xfs_iomap_eof_prealloc_initial_size() to
> xfs_fsblock_t to reflect the fact that the return value may be an
> unsigned 64 bits if XFS_BIG_BLKNOS is defined.
> 
> Signed-off-by: Mark Tinguely <tinguely@sgi.com>

Applied.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-03-07 18:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20130224190436.906161932@sgi.com>
2013-02-24 19:04 ` [PATCH] xfs: fix xfs_iomap_eof_prealloc_initial_size type Mark Tinguely
2013-02-24 23:37   ` Dave Chinner
2013-03-07 18:45   ` Ben Myers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox