Re: [PATCH] xfstests 273: fix a typo

David Sterba
2013-03-06T23:22:28Z

On Wed, Feb 27, 2013 at 02:47:54PM +0800, Wang Sheng-Hui wrote:
> Make the porter log cp failure into $seq.full by appending, not overwriting,
> which can help debug.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> ---
> 273 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/273 b/273
> index 67f3d6b..639e280 100755
> --- a/273
> +++ b/273
> @@ -92,7 +92,7 @@ _porter()
> exit
> fi
>
> - cp -r $SCRATCH_MNT/origin $SCRATCH_MNT/sub_$_suffix >$seq.full 2>&1
> + cp -r $SCRATCH_MNT/origin $SCRATCH_MNT/sub_$_suffix >>$seq.full 2>&1

This gives me

273 154s ... [20:05:00] [20:05:01] - output mismatch (see 273.out.bad)
--- 273.out 2011-11-11 15:13:46.000000000 +0100
+++ 273.out.bad 2013-03-06 20:05:01.000000000 +0100
@@ -1,4 +1,4 @@
QA output created by 273
-------------------------------
-start the workload
-------------------------------
+./273: line 95: syntax error near unexpected token `&'
+./273: line 95: ` cp -r $SCRATCH_MNT/origin $SCRATCH_MNT/sub_$_suffix >$seq.full 2>>&1'
+umount: /dev/sda9: not mounted
...
(Run 'diff -u 273.out 273.out.bad' to see the entire diff)
---

The script calls /bin/bash, my version says
GNU bash, version 4.1.10(1)-release

david