Re: [PATCH] xfstests 273: fix a typo

Dave Chinner
2013-03-07T22:48:36Z

On Thu, Mar 07, 2013 at 12:06:01PM +0100, David Sterba wrote:
> On Thu, Mar 07, 2013 at 02:38:49PM +1100, Dave Chinner wrote:
> > On Thu, Mar 07, 2013 at 12:22:22AM +0100, David Sterba wrote:
> > > On Wed, Feb 27, 2013 at 02:47:54PM +0800, Wang Sheng-Hui wrote:
> > > > - cp -r $SCRATCH_MNT/origin $SCRATCH_MNT/sub_$_suffix >$seq.full 2>&1
> > > > + cp -r $SCRATCH_MNT/origin $SCRATCH_MNT/sub_$_suffix >>$seq.full 2>&1
>
> This is quote from the mail, but the merged patch does something else.
>
> > > +./273: line 95: syntax error near unexpected token `&'
> > > +./273: line 95: ` cp -r $SCRATCH_MNT/origin $SCRATCH_MNT/sub_$_suffix >$seq.full 2>>&1'
> > > +umount: /dev/sda9: not mounted
>
> > that seems rather strange. The patch does this:
> >
> > ....sub_$_suffix >>$seq.full 2>&1
>
> http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/cmds/xfstests.git;a=commitdiff;h=0c5e67e46e476b70290033efc7feb784f7ecbab1;hp=08557e219c12e573be459407033495899f46967a

Oh....

> ---
>
> > and the error output you see is
> >
> > ....sub_$_suffix >$seq.full 2>>&1
> >
> > So it doesn't look lie you are running with the change that is
> > actually in the patch...
>
> There's a difference between the patch in mail and what has been merged, that
> can happen, but I wonder why it works on your side.

.... because I haven't updated to the latest xfstests master branch
yet - I'm running with the patch from the list applied. I didn't
realise you were running from the main repo, and that the commit was
busted...

Cheers,

Dave.

--
Dave Chinner
david@fromorbit.com