From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: skip freelist scans of corrupt agf
Date: Mon, 11 Mar 2013 13:02:05 +1100 [thread overview]
Message-ID: <20130311020205.GC21651@dastard> (raw)
In-Reply-To: <513B5393.4000203@sandeen.net>
On Sat, Mar 09, 2013 at 09:21:55AM -0600, Eric Sandeen wrote:
> If an agf has bad values in the freelist, this can wreak
> havoc if, for example, first > last and the loop
> never exits; we index agfl->agfl_bno[i] off into the weeds.
>
> If they're off, warn about it and skip the scan.
>
> Thisis done both in xfs_check and xfs_db's freespace cmd.
>
> Also fix uninit'd variable "i" from previous, similar fix
> for xfs_repair.
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-11 2:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 15:21 [PATCH] xfsprogs: skip freelist scans of corrupt agf Eric Sandeen
2013-03-11 2:02 ` Dave Chinner [this message]
2013-03-11 12:16 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130311020205.GC21651@dastard \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox