From: Dave Chinner <david@fromorbit.com>
To: David Sterba <dsterba@suse.cz>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: determine path of logger
Date: Tue, 12 Mar 2013 12:21:52 +1100 [thread overview]
Message-ID: <20130312012152.GG21651@dastard> (raw)
In-Reply-To: <1363045012-21119-1-git-send-email-dsterba@suse.cz>
On Tue, Mar 12, 2013 at 12:36:52AM +0100, David Sterba wrote:
> The path of the syslog writer utility 'logger' is hardcoded and not
> always correct, use set_prog_path.
>
> Signed-off-by: David Sterba <dsterba@suse.cz>
> ---
> check | 2 +-
> common.config | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/check b/check
> index c20179c..9a5b256 100755
> --- a/check
> +++ b/check
> @@ -243,7 +243,7 @@ do
> start=`_wallclock`
> $timestamp && echo -n " ["`date "+%T"`"]"
> [ ! -x $seq ] && chmod u+x $seq # ensure we can run it
> - [ -x /usr/bin/logger ] && /usr/bin/logger "run xfstest $seq"
> + $LOGGER_PROG "run xfstest $seq"
> ./$seq >$tmp.rawout 2>&1
> sts=$?
> $timestamp && _timestamp
> diff --git a/common.config b/common.config
> index a0b017d..ed0f44c 100644
> --- a/common.config
> +++ b/common.config
> @@ -177,6 +177,7 @@ export DUMPE2FS_PROG="`set_prog_path dumpe2fs`"
> export FIO_PROG="`set_prog_path fio`"
> export FILEFRAG_PROG="`set_prog_path filefrag`"
> export E4DEFRAG_PROG="`set_prog_path e4defrag`"
> +export LOGGER_PROG="`set_prog_path logger`"
>
> # Generate a comparable xfsprogs version number in the form of
> # major * 10000 + minor * 100 + release
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-12 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 23:36 [PATCH] xfstests: determine path of logger David Sterba
2013-03-12 1:21 ` Dave Chinner [this message]
2013-03-12 12:52 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312012152.GG21651@dastard \
--to=david@fromorbit.com \
--cc=dsterba@suse.cz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox