From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id E7F207FAA for ; Thu, 14 Mar 2013 18:21:01 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id A77178F8059 for ; Thu, 14 Mar 2013 16:21:01 -0700 (PDT) Received: from mail.lichtvoll.de (mondschein.lichtvoll.de [194.150.191.11]) by cuda.sgi.com with ESMTP id 5G5672ykUlPTU7Zm for ; Thu, 14 Mar 2013 16:20:59 -0700 (PDT) From: Martin Steigerwald Subject: Re: [PATCH] xfstests: test writing to device node on an RO filesystem Date: Fri, 15 Mar 2013 00:20:56 +0100 References: <514243C0.1000309@redhat.com> (sfid-20130315_001049_792066_0DB10787) In-Reply-To: <514243C0.1000309@redhat.com> MIME-Version: 1.0 Message-Id: <201303150020.57326.Martin@lichtvoll.de> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: xfs@oss.sgi.com Cc: Eric Sandeen Am Donnerstag, 14. M=E4rz 2013 schrieb Eric Sandeen: > we should be able to open device nodes for writing even > if they live on a readonly filesytem. Just saw a typo. See below. = > Signed-off-by: Eric Sandeen > --- > = > (I may have *cough* broken this on a backport once, hence the test) > = > diff --git a/315 b/315 > new file mode 100755 > index 0000000..8b8ecc6 > --- /dev/null > +++ b/315 > @@ -0,0 +1,79 @@ > +#! /bin/bash > +# FS QA Test No. 315 > +# > +# Test that we can write to a device node residing on a RO filesystem > +# > +#----------------------------------------------------------------------- > +# Copyright (c) 2013 Red Hat, Inc. All Rights Reserved. > +# > +# This program is free software; you can redistribute it and/or > +# modify it under the terms of the GNU General Public License as > +# published by the Free Software Foundation. > +# > +# This program is distributed in the hope that it would be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program; if not, write the Free Software Foundation, > +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > +#----------------------------------------------------------------------- > +# > +# creator > +owner=3Dsandeen@redhat.com > + > +seq=3D`basename $0` > +echo "QA output created by $seq" > + > +here=3D`pwd` > +tmp=3D/tmp/$$ > +status=3D1 # failure is the default! > +trap "_cleanup; exit \$status" 0 1 2 3 15 > + > +_cleanup() > +{ > + cd / > + rm -f $tmp.* > +} > + > +# get standard environment, filters and checks > +. ./common.rc > +. ./common.filter > + > +# real QA test starts here > + > +# Modify as appropriate. > +_supported_fs generic > +_supported_os Linux > +_require_scratch > + > +DEVNULL=3D$SCRATCH_MNT/devnull > +DEVZERO=3D$SCRATCH_MNT/devzero > + > +_scratch_mount > + > +rm -f $DEVNULL $DEVZERO > + > +mknod $DEVNULL c 1 3 || _fail "Could not create devnull device" > +mknod $DEVZERO c 1 5 || _fail "Could not create devzero device" > + > +_scratch_unmount || _fail "Could not unmount scratch device" > +_scratch_mount -o ro || _fail "Could not remount scratch readonly" > + > +# We should be able to read & write to/from these devices even on an RO > fs +echo "=3D=3D try to create new file" > +touch $SCRATCH_MNT/this_should_fail 2>&1 | _filter_scratch > +echo "=3D=3D prite to null device" prite =3D> pwrite > +xfs_io -c "pwrite 0 512" /dev/null | _filter_xfs_io > +echo "=3D=3D pread from zero device" > +xfs_io -c "pread 0 512" /dev/zero | _filter_xfs_io > + > +echo "=3D=3D truncating write to null device" > +echo foo >> $DEVNULL 2>&1 | _filter_scratch > +echo "=3D=3D appending write to null device" > +echo foo >> $DEVNULL 2>&1 | _filter_scratch > + > +# success, all done > +status=3D0 > +exit > diff --git a/315.out b/315.out > new file mode 100644 > index 0000000..d07c567 > --- /dev/null > +++ b/315.out > @@ -0,0 +1,11 @@ > +QA output created by 315 > +=3D=3D try to create new file > +touch: cannot touch `SCRATCH_MNT/this_should_fail': Read-only file > system +=3D=3D prite to null device > +wrote 512/512 bytes at offset 0 > +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +=3D=3D pread from zero device > +read 512/512 bytes at offset 0 > +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +=3D=3D truncating write to null device > +=3D=3D appending write to null device > diff --git a/group b/group > index fcbdfb6..fd838ef 100644 > --- a/group > +++ b/group > @@ -430,3 +430,4 @@ stress > 305 aio dangerous enospc rw stress > 313 auto quick > 314 auto > +315 auto rw Thanks, -- = Martin 'Helios' Steigerwald - http://www.Lichtvoll.de GPG: 03B0 0D6C 0040 0710 4AFA B82F 991B EAAC A599 84C7 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs