From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 32BC17FB6 for ; Thu, 14 Mar 2013 20:13:49 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 0D8978F8033 for ; Thu, 14 Mar 2013 18:13:45 -0700 (PDT) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id XHnLHXGxQU8f3Tti for ; Thu, 14 Mar 2013 18:13:44 -0700 (PDT) Date: Fri, 15 Mar 2013 12:13:43 +1100 From: Dave Chinner Subject: Re: [PATCH 02/21] xfs: increase hexdump output in xfs_corruption_error Message-ID: <20130315011343.GE21651@dastard> References: <1363091454-8852-1-git-send-email-david@fromorbit.com> <1363091454-8852-3-git-send-email-david@fromorbit.com> <20130314211817.GX22182@sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130314211817.GX22182@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Ben Myers Cc: xfs@oss.sgi.com On Thu, Mar 14, 2013 at 04:18:17PM -0500, Ben Myers wrote: > On Tue, Mar 12, 2013 at 11:30:35PM +1100, Dave Chinner wrote: > > From: Dave Chinner > > > > Currently xfs_corruption_error() dumps the first 16 bytes of the > > buffer that is passed to it when a corruption occurs. This is not > > large enough to see the entire state of the header of the block that > > was determined to be corrupt. increase the output to 64 bytes to > > capture the majority of all headers in all types of metadata blocks. > > > > Signed-off-by: Dave Chinner > > --- > > fs/xfs/xfs_error.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c > > index 07bf3b9..35d3f5b 100644 > > --- a/fs/xfs/xfs_error.c > > +++ b/fs/xfs/xfs_error.c > > @@ -178,7 +178,7 @@ xfs_corruption_error( > > inst_t *ra) > > { > > if (level <= xfs_error_level) > > - xfs_hex_dump(p, 16); > > + xfs_hex_dump(p, 64); > > Are you sure we don't have any structures which are shorter than that? I guess > we'll have to take a look. We only ever pass it buffers or struct xfs_dinode, both of which are always guaranteed to be larger than 64 bytes. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs