From: Dave Chinner <david@fromorbit.com>
To: Subranshu Patel <spatel.ml@gmail.com>
Cc: stan@hardwarefreak.com, xfs@oss.sgi.com
Subject: Re: Xfs_repair and journalling
Date: Mon, 18 Mar 2013 10:20:05 +1100 [thread overview]
Message-ID: <20130317232005.GK6369@dastard> (raw)
In-Reply-To: <CAEUQceie41dh7h6uZSMu4-JB_BDu82X5CrKxHb=9wVQVAPzKgQ@mail.gmail.com>
On Sun, Mar 17, 2013 at 05:12:36PM +0530, Subranshu Patel wrote:
> What I understand is that, XFS being a journalling filesystem makes running
> xfs_repair after a unclean unmount unnecessary.
Correct.
> After a system crash or force power down, one can mount the filesystem
> which causes the journal to be replayed and handles the half finished
> writes.
What "half finished writes"? The journal replays only completely
written checkpoints. It tosses away half written writes because they
are not complete and so replaying them will result in filesystem
corruption....
> This is one part. But there can be other file corruption as well
> and these can be handled by xfs_repair.
I think you don't understand how OS level writeback caching works.
You will *lose* data on a power failure unless the application
spcifically writes it to disk with fdatasync/fsync(). This has
nothing to do with the filesystem, nor journal replay. If the
application uses fsync, then the data on disk is consistent with
what is in the journal, so after journal replay, the data is there
on disk.
xfs_reapir is not full of magic pixie dust that miraculously
recovers data that was never written to disk....
> In case of EXT4, journal will not be replayed on performing mount. One need
> to invoke fsck which performs journal playback and then other corruption
> checks/recovery.
> Correct me if I am wrong.
ext4 behaves like this, but your basic assumption that fsck.ext4
performs data recovery/repair is wrong, same as for your assumption
that xfs_repair does this for XFS.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-17 23:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-16 15:56 Xfs_repair and journalling Subranshu Patel
2013-03-17 2:22 ` Stan Hoeppner
2013-03-17 3:01 ` Michael L. Semon
2013-03-17 5:26 ` Stan Hoeppner
2013-03-17 11:42 ` Subranshu Patel
2013-03-17 14:50 ` Stan Hoeppner
2013-03-17 15:18 ` Matthias Schniedermeyer
2013-03-17 23:20 ` Dave Chinner [this message]
2013-03-18 18:22 ` Ben Myers
2013-03-18 20:58 ` Martin Steigerwald
2013-03-18 20:50 ` Martin Steigerwald
2013-03-19 4:02 ` Eric Sandeen
2013-03-19 6:19 ` Stan Hoeppner
2013-03-19 8:24 ` Martin Steigerwald
2013-03-19 10:14 ` Stan Hoeppner
2013-03-30 12:49 ` Xfs_repair and journalling -- EXT4 journal replay discussion Stan Hoeppner
2013-03-30 17:40 ` Eric Sandeen
2013-03-30 18:52 ` Stan Hoeppner
2013-03-30 20:21 ` Eric Sandeen
2013-03-31 11:24 ` Stan Hoeppner
2013-03-31 2:03 ` Dave Chinner
2013-03-31 1:35 ` Dave Chinner
2013-03-18 20:37 ` Xfs_repair and journalling Martin Steigerwald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130317232005.GK6369@dastard \
--to=david@fromorbit.com \
--cc=spatel.ml@gmail.com \
--cc=stan@hardwarefreak.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox