Bug#695640: xfs_quota: cannot find mount point for path: Success

Bug#695640: xfs_quota: cannot find mount point for path: Success

[Brian May]

[-- Attachment #1.1: Type: text/plain, Size: 2168 bytes --]

Package: xfsprogs
Version: 3.1.4


hq ~ # /usr/sbin/xfs_quota -x -c "quota -N -u brian" /home
xfs_quota: cannot find mount point for path `/share/systems': Success
xfs_quota: cannot find mount point for path `/share/cs': Success
xfs_quota: cannot find mount point for path `/share/cas': Success
xfs_quota: cannot find mount point for path `/share/cfcp': Success
xfs_quota: cannot find mount point for path `/share/lgs': Success
xfs_quota: cannot find mount point for path `/share/common': Success
xfs_quota: cannot find mount point for path `/share/summer': Success
/dev/mapper/hq-home    3763680          0          0   00 [--------] /home


Why is it complaining about success?

These messages only occurred after upgrading a lenny system to squeeze.


strace shows no errors at this point:

write(2, "xfs_quota: cannot find mount poi"..., 70xfs_quota: cannot find
mount point for path `/share/systems': Success
) = 70
stat64("/share/cs", {st_mode=S_IFDIR|S_ISGID|0755, st_size=118, ...}) = 0
write(2, "xfs_quota: cannot find mount poi"..., 65xfs_quota: cannot find
mount point for path `/share/cs': Success
) = 65
stat64("/share/cas", {st_mode=S_IFDIR|S_ISGID|0775, st_size=117, ...}) = 0
write(2, "xfs_quota: cannot find mount poi"..., 66xfs_quota: cannot find
mount point for path `/share/cas': Success
) = 66
stat64("/share/cfcp", {st_mode=S_IFDIR|S_ISGID|0755, st_size=99, ...}) = 0
write(2, "xfs_quota: cannot find mount poi"..., 67xfs_quota: cannot find
mount point for path `/share/cfcp': Success
) = 67
stat64("/share/lgs", {st_mode=S_IFDIR|S_ISGID|0750, st_size=89, ...}) = 0
write(2, "xfs_quota: cannot find mount poi"..., 66xfs_quota: cannot find
mount point for path `/share/lgs': Success
) = 66
stat64("/share/common", {st_mode=S_IFDIR|S_ISGID|0755, st_size=96, ...}) = 0
write(2, "xfs_quota: cannot find mount poi"..., 69xfs_quota: cannot find
mount point for path `/share/common': Success
) = 69
stat64("/share/summer", {st_mode=S_IFDIR|S_ISGID|0770, st_size=4096, ...})
= 0
write(2, "xfs_quota: cannot find mount poi"..., 69xfs_quota: cannot find
mount point for path `/share/summer': Success
) = 69


-- 
Brian May <brian@microcomaustralia.com.au>

[-- Attachment #1.2: Type: text/html, Size: 2975 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Bug#695640: xfs_quota: cannot find mount point for path: Success

[Brian May]

[-- Attachment #1.1: Type: text/plain, Size: 301 bytes --]

On 12 December 2012 10:20, Brian May <brian@microcomaustralia.com.au> wrote:

> On 12 December 2012 10:15, Dave Chinner <david@fromorbit.com> wrote:
>
>> Full strace output, please.
>
>
> Attached.
>

Did my strace output help diagnose this bug?

Thanks
-- 
Brian May <brian@microcomaustralia.com.au>

[-- Attachment #1.2: Type: text/html, Size: 1017 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Bug#695640: xfs_quota: cannot find mount point for path: Success

[Dave Chinner]

On Mon, Mar 18, 2013 at 11:30:35AM +1100, Brian May wrote:
> On 12 December 2012 10:20, Brian May <brian@microcomaustralia.com.au> wrote:
> 
> > On 12 December 2012 10:15, Dave Chinner <david@fromorbit.com> wrote:
> >
> >> Full strace output, please.
> >
> >
> > Attached.
> >
> 
> Did my strace output help diagnose this bug?

No, but it's most likely the same problem as fixed in commit
19473a2ac. Can you add this to quota/quot.c:quot_init():

+	quot_cmd.flags = CMD_FLAG_GLOBAL;

And see if the problem goes away?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Bug#695640: xfs_quota: cannot find mount point for path: Success

[Brian May]

[-- Attachment #1.1: Type: text/plain, Size: 1105 bytes --]

On 19 March 2013 09:48, Dave Chinner <david@fromorbit.com> wrote:

> > Did my strace output help diagnose this bug?
>
> No, but it's most likely the same problem as fixed in commit
> 19473a2ac. Can you add this to quota/quot.c:quot_init():
>
> +       quot_cmd.flags = CMD_FLAG_GLOBAL;
>
> And see if the problem goes away?
>

I made this change to the version in Debian squeeze.

I didn't see any change in behaviour :-(

hq ~ # xfs_quota  -x -c "quota -N -u brian" /home
xfs_quota: cannot find mount point for path `/share/systems': Success
xfs_quota: cannot find mount point for path `/share/cs': Success
xfs_quota: cannot find mount point for path `/share/cas': Success
xfs_quota: cannot find mount point for path `/share/cfcp': Success
xfs_quota: cannot find mount point for path `/share/lgs': Success
xfs_quota: cannot find mount point for path `/share/common': Success
xfs_quota: cannot find mount point for path `/share/summer': Success
/dev/mapper/hq-home    3800752          0          0   00 [--------] /home

Also tried the same patch against the latest git version, and got the same
problem.

[-- Attachment #1.2: Type: text/html, Size: 2262 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Bug#695640: xfs_quota: cannot find mount point for path: Success

[Dave Chinner]

On Tue, Mar 19, 2013 at 03:51:30PM +1100, Brian May wrote:
> On 19 March 2013 09:48, Dave Chinner <david@fromorbit.com> wrote:
> 
> > > Did my strace output help diagnose this bug?
> >
> > No, but it's most likely the same problem as fixed in commit
> > 19473a2ac. Can you add this to quota/quot.c:quot_init():
> >
> > +       quot_cmd.flags = CMD_FLAG_GLOBAL;
> >
> > And see if the problem goes away?
> >
> 
> I made this change to the version in Debian squeeze.
> 
> I didn't see any change in behaviour :-(
> 
> hq ~ # xfs_quota  -x -c "quota -N -u brian" /home
> xfs_quota: cannot find mount point for path `/share/systems': Success
> xfs_quota: cannot find mount point for path `/share/cs': Success
> xfs_quota: cannot find mount point for path `/share/cas': Success
> xfs_quota: cannot find mount point for path `/share/cfcp': Success
> xfs_quota: cannot find mount point for path `/share/lgs': Success
> xfs_quota: cannot find mount point for path `/share/common': Success
> xfs_quota: cannot find mount point for path `/share/summer': Success
> /dev/mapper/hq-home    3800752          0          0   00 [--------] /home

Which tells me exactly what is happening.

The project quotas are not on the filesystem you directed the the
quota command at, and xfs_quota is telling you that it can't find
the mount point for the configured project quotas on /home. Either:

# xfs_quota  -x -c "quota -N -u brian"

or

# xfs_quota  -x -c "quota -N -u brian" /home /share

will not output the error message because xfs_quota knows about the
locations of the project quotas.

Yes, it's not obvious what is happening here but technically it
isn't a bug, either, because you told xfs_quota not to load
information about any other mountpoint.

I'll have a think about how to make this output less .... obtuse.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Bug#695640: xfs_quota: cannot find mount point for path: Success

[Brian May]

[-- Attachment #1.1: Type: text/plain, Size: 1543 bytes --]

On 19 March 2013 17:31, Dave Chinner <david@fromorbit.com> wrote:

> Which tells me exactly what is happening.
>
> The project quotas are not on the filesystem you directed the the
> quota command at, and xfs_quota is telling you that it can't find
> the mount point for the configured project quotas on /home. Either:
>

Hello,

Thanks for your response.

I am kind of confused still. I asked for user quotas, with the -u flag. Why
should it be trying to lookup project quotas?

I only want to get the report of user quotas. I only want to get the report
for one filesystem. A filesystem that
doesn't support project quotas, which should be fine because I am not
asking for project quotas.

This was fine under lenny, but broke under squeeze.



> # xfs_quota  -x -c "quota -N -u brian"
>

This prints the quota information 20 times. Huh?


> or
>
> # xfs_quota  -x -c "quota -N -u brian" /home /share
>

This prints the quota information 2 times. Huh?

hq ~ # xfs_quota  -x -c "quota -u brian" /home /share
Disk quotas for User brian (10000)
Filesystem              Blocks      Quota      Limit  Warn/Time
 Mounted on
/dev/mapper/hq-home    3799724          0          0   00 [--------] /home
/dev/mapper/hq-share     282856          0          0   00 [--------] /share
Disk quotas for User brian (10000)
Filesystem              Blocks      Quota      Limit  Warn/Time
 Mounted on
/dev/mapper/hq-home    3799724          0          0   00 [--------] /home
/dev/mapper/hq-share     282856          0          0   00 [--------] /share

Thanks

[-- Attachment #1.2: Type: text/html, Size: 2980 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Bug#695640: xfs_quota: cannot find mount point for path: Success

[Dave Chinner]

On Wed, Mar 20, 2013 at 04:19:16PM +1100, Brian May wrote:
> On 19 March 2013 17:31, Dave Chinner <david@fromorbit.com> wrote:
> 
> > Which tells me exactly what is happening.
> >
> > The project quotas are not on the filesystem you directed the the
> > quota command at, and xfs_quota is telling you that it can't find
> > the mount point for the configured project quotas on /home. Either:
> >
> 
> Hello,
> 
> Thanks for your response.
> 
> I am kind of confused still. I asked for user quotas, with the -u flag. Why
> should it be trying to lookup project quotas?

Because the quota command does mount point and project quota
initialisation (i.e. global state) before it parses any specific
command.

> I only want to get the report of user quotas. I only want to get the report
> for one filesystem. A filesystem that
> doesn't support project quotas, which should be fine because I am not
> asking for project quotas.

The issues project quota configuration is global information, and
the initialisation code is not aware of the fact that:

	a) you are not asking for project quota information; and
	b) you are not asking for information about a mount point
	   that doesn't have any project quotas on it.

> > # xfs_quota  -x -c "quota -N -u brian"
> 
> This prints the quota information 20 times. Huh?

How many mount points do you have? 20?

> > or
> >
> > # xfs_quota  -x -c "quota -N -u brian" /home /share
> >
> 
> This prints the quota information 2 times. Huh?

The command has once for each of the mount points, and the command
itself iterates mount points because you haven't given it a mount
point to look at. So, double iteration.  This same problem was fixed
for the report command by setting it to be a global command i.e. the
fix I mentioned previously that you tested should prevent this
second case, and maybe even the first.

There are several layers of interactions here, and that's why I need
to have a think about it to understand it fully and fix it....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Bug#695640: xfs_quota: cannot find mount point for path: Success

[Brian May]

[-- Attachment #1.1: Type: text/plain, Size: 1705 bytes --]

Oops. Just realized I still hadn't responded. Sorry.


On 20 March 2013 22:09, Dave Chinner <david@fromorbit.com> wrote:

> > > # xfs_quota  -x -c "quota -N -u brian"
> >
> > This prints the quota information 20 times. Huh?
>
> How many mount points do you have? 20?
>

No. More actually. Today I get

hq ~ # cat /proc/mounts  | wc --lines
34
hq ~ # xfs_quota  -x -c "quota -N -u brian" | wc --lines
44
hq ~ # xfs_quota  -x -c "quota -N -u brian" /home /share | wc --lines
4


> The command has once for each of the mount points, and the command
> itself iterates mount points because you haven't given it a mount
> point to look at. So, double iteration.  This same problem was fixed
> for the report command by setting it to be a global command i.e. the
> fix I mentioned previously that you tested should prevent this
> second case, and maybe even the first.
>

As far as I can tell this happens with the patched xfs_quota.

hq /home/brian/xfsprogs # git diff
diff --git a/quota/quot.c b/quota/quot.c
index a7782b4..6cb665d 100644
--- a/quota/quot.c
+++ b/quota/quot.c
@@ -418,6 +418,7 @@ quot_init(void)
        quot_cmd.args = _("[-bir] [-gpu] [-acv] [-f file]");
        quot_cmd.oneline = _("summarize filesystem ownership");
        quot_cmd.help = quot_help;
+       quot_cmd.flags = CMD_FLAG_GLOBAL;

        if (expert)
                add_command(&quot_cmd);

As this version is based on git, I just did a git pull:

hq /home/brian/xfsprogs # git pull
Updating b326e06..64ae7fc
Fast-forward
 mkfs/xfs_mkfs.c |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)

Doesn't look related to this, don't think I need to retest.
-- 
Brian May <brian@microcomaustralia.com.au>

[-- Attachment #1.2: Type: text/html, Size: 3069 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs