From: Dave Chinner <david@fromorbit.com>
To: Ben Myers <bpm@sgi.com>
Cc: Rich Johnston <rjohnston@sgi.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 01/13] xfstests: filter new repair/mkfs output for CRCs
Date: Wed, 20 Mar 2013 09:52:30 +1100 [thread overview]
Message-ID: <20130319225230.GB17758@dastard> (raw)
In-Reply-To: <20130319205801.GG22182@sgi.com>
On Tue, Mar 19, 2013 at 03:58:01PM -0500, Ben Myers wrote:
> Hey Rich,
>
> On Fri, Mar 15, 2013 at 10:53:19PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > This patch it to ensure that xfstests passes on non-crc filesystems
> > with a CRC enabled userspace.
> >
> > Filter out the mkfs/xfs_info CRC line from tests that capture the
> > output of these commands.
> >
> > Filter out new error noise from xfs_repair that occurs for
> > xfs_repair as a result of the CRC changes.
>
> IIRC this change was a temporary one so that xfstests could be run with crc
> enabled filesystems.
It's going to be a permanent change because we dump mkfs.xfs output
into golden output files and that means the "crc=X" line will always
need to be filtered out
> > diff --git a/common.repair b/common.repair
> > index 23a1ed6..db160bb 100644
> > --- a/common.repair
> > +++ b/common.repair
> > @@ -77,6 +77,9 @@ s/\s+- \d+:\d\d:\d\d:.*\n//g;
> > /^agi_/ && next; # remove agi counts
> > /^sb_/ && next; # remove sb counts
> > /^agi unlinked/ && next; # remove agi unlinked bucket warning
> > +# crc enabled filesystem output
> > +/XFS_CORRUPTION_ERROR/ && next;
> > +/^bad uuid/ && next;
>
> Doesn't this filter out xfs repair failures which should be reported?
No, because repair will issue errors when bad metadata is read off
disk now, and as such they are brand new output introduced by the
CRC patches. Over time this might get cleaned up, but at least for
initial testing and debugging this noise will remain in the repair
code....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-19 22:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 11:53 [PATCH 00/13] xfstests: generic --large-fs support Dave Chinner
2013-03-15 11:53 ` [PATCH 01/13] xfstests: filter new repair/mkfs output for CRCs Dave Chinner
2013-03-19 19:44 ` Rich Johnston
2013-03-19 20:58 ` Ben Myers
2013-03-19 22:52 ` Dave Chinner [this message]
2013-03-15 11:53 ` [PATCH 02/13] xfstests: add --largefs check option Dave Chinner
2013-03-15 11:53 ` [PATCH 03/13] xfstests: rename USE_BIG_LOOPFS to be more generic Dave Chinner
2013-03-19 19:46 ` Rich Johnston
2013-03-15 11:53 ` [PATCH 04/13] xfstests: rename RETAIN_AG_BYTES Dave Chinner
2013-03-15 11:53 ` [PATCH 05/13] xfstests: use preallocation for ag-wiper Dave Chinner
2013-03-19 19:47 ` Rich Johnston
2013-03-15 11:53 ` [PATCH 06/13] xfstests: use command line option for setting extra space Dave Chinner
2013-03-15 11:53 ` [PATCH 07/13] xfstest: enable xfs_repair for large filesystem testing Dave Chinner
2013-03-15 11:53 ` [PATCH 08/13] xfstests: always use test option when checking large scratch device Dave Chinner
2013-03-15 11:53 ` [PATCH 09/13] xfstests: enable large fs testing on ext4 Dave Chinner
2013-03-15 11:53 ` [PATCH 10/13] xfstests: disable tests that typically fail on large filesystems Dave Chinner
2013-03-15 11:53 ` [PATCH 11/13] xfstests: exclude largefs fill files from dump tests Dave Chinner
2013-03-19 19:49 ` Rich Johnston
2013-03-15 11:53 ` [PATCH 12/13] xfstests: filter files in 019 for --large-fs Dave Chinner
2013-03-19 19:52 ` Rich Johnston
2013-03-15 11:53 ` [PATCH 13/13] xfstests: correct quota file count " Dave Chinner
2013-03-19 19:52 ` Rich Johnston
2013-03-19 20:20 ` [PATCH 00/13] xfstests: generic --large-fs support Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319225230.GB17758@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=rjohnston@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox