From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 33D757F37 for ; Wed, 20 Mar 2013 20:37:36 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id 1D2CA304048 for ; Wed, 20 Mar 2013 18:37:36 -0700 (PDT) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id vDIXCi5UmjEpRFHL for ; Wed, 20 Mar 2013 18:37:34 -0700 (PDT) Date: Thu, 21 Mar 2013 12:37:33 +1100 From: Dave Chinner Subject: Re: [PATCH] xfs: Fix WARN_ON(delalloc) in xfs_vm_releasepage() Message-ID: <20130321013733.GK17758@dastard> References: <1363267854-25602-1-git-send-email-jack@suse.cz> <20130315205214.GB22182@sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130315205214.GB22182@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Ben Myers Cc: Jan Kara , xfs@oss.sgi.com On Fri, Mar 15, 2013 at 03:52:14PM -0500, Ben Myers wrote: > Hi Jan, > > On Thu, Mar 14, 2013 at 02:30:54PM +0100, Jan Kara wrote: > > When a dirty page is truncated from a file but reclaim gets to it before > > truncate_inode_pages(), we hit WARN_ON(delalloc) in > > xfs_vm_releasepage(). This is because reclaim tries to write the page, > > xfs_vm_writepage() just bails out (leaving page clean) and thus reclaim > > thinks it can continue and calls xfs_vm_releasepage() on page with dirty > > buffers. > > > > Fix the issue by redirtying the page in xfs_vm_writepage(). This makes > > reclaim stop reclaiming the page and also logically it keeps page in a > > more consistent state where page with dirty buffers has PageDirty set. > > Was there an easy way to reproduce this? I'm testing and reviewing this now > and it might help. This patch has been confirmed to fix the report generated by the DB workload I mentioned in another part of the thread. Hence I think it should be good to go. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs