From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-ext4@vger.kernel.org, Zheng Liu <gnehzuil.liu@gmail.com>,
Zheng Liu <wenqing.lz@taobao.com>,
xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests 299-305: remove fio config files after finished test
Date: Thu, 21 Mar 2013 13:47:42 +1100 [thread overview]
Message-ID: <20130321024742.GM17758@dastard> (raw)
In-Reply-To: <514A6B5F.7000705@redhat.com>
On Wed, Mar 20, 2013 at 09:07:27PM -0500, Eric Sandeen wrote:
> On 3/20/13 8:09 PM, Dave Chinner wrote:
> > On Tue, Mar 19, 2013 at 05:30:50PM +0800, Zheng Liu wrote:
> >> From: Zheng Liu <wenqing.lz@taobao.com>
> >>
> >> After finished test, temporarily fio config file should be removed.
> >>
> >> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
> >> ---
> >> 299 | 2 +-
> >> 300 | 2 +-
> >> 301 | 2 +-
> >> 302 | 2 +-
> >> 303 | 2 +-
> >> 304 | 2 +-
> >> 305 | 1 +
> >> 7 files changed, 7 insertions(+), 6 deletions(-)
> >>
> >> diff --git a/299 b/299
> >> index 4305ead..9d0c32f 100644
> >> --- a/299
> >> +++ b/299
> >> @@ -32,7 +32,7 @@ echo "QA output created by $seq"
> >> here=`pwd`
> >> tmp=/tmp/$$
> >> status=1 # failure is the default!
> >> +trap "rm -f $tmp.*; rm -f $tmp-$seq.fio; exit \$status" 0 1 2 3 15
> >
> > Umm, wouldn't this be better:
> >
> > -trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15
> > +trap "rm -f $tmp*; exit \$status" 0 1 2 3 15
> >
>
> Naming the files $tmp.fio would have worked too, but *shrug*
> doesn't seem that critical. Still:
>
> > 2. You can safely create temporary files that are not part of the
> > filesystem tests (e.g. to catch output, prepare lists of things
> > to do, etc.) in files named $tmp.<anything>. The standard test
> > script framework created by "new" will initialize $tmp and
> > cleanup on exit.
Good point. With that in mind, I think renaming the fio files is the
right thing to do, not changing the traps to have to handle
arbitrary tmp file names...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-03-21 2:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 9:30 [PATCH] xfstests 299-305: remove fio config files after finished test Zheng Liu
2013-03-19 16:19 ` Eric Sandeen
2013-03-20 5:37 ` Zheng Liu
2013-03-21 1:09 ` Dave Chinner
2013-03-21 2:07 ` Eric Sandeen
2013-03-21 2:47 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321024742.GM17758@dastard \
--to=david@fromorbit.com \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=wenqing.lz@taobao.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox