From: Dave Chinner <david@fromorbit.com>
To: Jan Schmidt <list.xfs@jan-o-sch.net>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: add execution of a custom command to fsstress (-x and -X options)
Date: Fri, 22 Mar 2013 08:12:18 +1100 [thread overview]
Message-ID: <20130321211218.GP17758@dastard> (raw)
In-Reply-To: <514B72B9.1010005@jan-o-sch.net>
On Thu, Mar 21, 2013 at 09:51:05PM +0100, Jan Schmidt wrote:
>
>
> On 21.03.2013 20:50, Dave Chinner wrote:
> > On Thu, Mar 21, 2013 at 11:59:45AM +0100, Jan Schmidt wrote:
> >> From: Jan Schmidt <list.btrfs@jan-o-sch.net>
> >>
> >> This patch adds execution of a custom command in the middle of all fsstress
> >> operations. Its intended use is the creation of snapshots in the middle of a
> >> test run.
> >
> > Why do you need fsstress to do this? Why can't you just run fsstress
> > in the background and run a loop creating periodic snapshots in the
> > control script?
>
> Because I want reproducible results. Same random seed should result in
> the very same snapshots being created.
Why can't you run fsstress for N operations, run a snapshot,
then run it again for M operations? That will give you exactly the
same results, wouldn't it?
> > Also, did you intend that every process creates a snapshot? i.e. it
> > looks lik eif you run a 1000 processes, they'll all run a snapshot
> > operation at X operations? i.e. this will generate nproc * X
> > snapshots in a single run. This doesn't seem very wise to me....
>
> Agreed, I haven't thought of running more than one process. For the sake
> of reproducibility, I wouldn't want multiple processes for my test case
> either.
>
> I'm not sure if there are other applications than snapshot creation for
> such a feature, so I cannot argue whether to have each process execute
> such a command or not.
If such a feature is necessary, I'd suggest that implementing the
snapshot ioctl as just another operation directly into fsstress is
probably a better way to implement this functionality. That way you
can control the frequency via the command line in exactly the same
way as every other operation....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-21 21:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 10:59 [PATCH] xfstests: add execution of a custom command to fsstress (-x and -X options) Jan Schmidt
2013-03-21 19:50 ` Dave Chinner
2013-03-21 20:51 ` Jan Schmidt
2013-03-21 21:12 ` Dave Chinner [this message]
2013-03-22 7:06 ` Jan Schmidt
2013-03-24 23:51 ` Dave Chinner
2013-04-05 12:07 ` Jan Schmidt
2013-05-03 14:43 ` Jan Schmidt
2013-05-09 19:47 ` Rich Johnston
2013-05-09 19:50 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321211218.GP17758@dastard \
--to=david@fromorbit.com \
--cc=list.xfs@jan-o-sch.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox