From: Phil White <pwhite@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 09/25] xfstests: remove undocumented TESTS_REMAINING_LOG
Date: Sat, 23 Mar 2013 03:20:17 -0700 [thread overview]
Message-ID: <20130323102016.GM25253@caliban.engr.sgi.com> (raw)
In-Reply-To: <1363350489-22257-10-git-send-email-david@fromorbit.com>
Looks OK.
Reviewed-by: Phil White <pwhite@sgi.com>
On Fri, Mar 15, 2013 at 11:27:53PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Undocumented and unused, AFAICT. Kill it.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
> ---
> check | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/check b/check
> index 8a998c4..b93316a 100755
> --- a/check
> +++ b/check
> @@ -365,17 +365,10 @@ fi
> seq="check"
> _check_test_fs
>
> -[ -n "$TESTS_REMAINING_LOG" ] && echo $list > $TESTS_REMAINING_LOG
> -
> for seq in $list
> do
> err=false
> echo -n "$seq"
> - if [ -n "$TESTS_REMAINING_LOG" ] ; then
> - sed -e "s/$seq//" -e 's/ / /' -e 's/^ *//' $TESTS_REMAINING_LOG > $TESTS_REMAINING_LOG.tmp
> - mv $TESTS_REMAINING_LOG.tmp $TESTS_REMAINING_LOG
> - sync
> - fi
>
> if $showme
> then
> --
> 1.7.10.4
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-23 10:20 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 12:27 [PATCH 00/25] xfstests: xfstests: move tests out of top level Dave Chinner
2013-03-15 12:27 ` [PATCH 01/25] xfstests: remove remake script Dave Chinner
2013-03-22 16:51 ` Phil White
2013-03-15 12:27 ` [PATCH 02/25] xfstests: remove bench infrastructure Dave Chinner
2013-03-15 19:36 ` Phil White
2013-03-19 22:31 ` Dave Chinner
2013-03-21 23:52 ` Phil White
2013-03-22 7:37 ` Dave Chinner
2013-03-22 16:22 ` Troy McCorkell
2013-03-26 20:26 ` Troy McCorkell
2013-03-22 16:53 ` Phil White
2013-03-15 12:27 ` [PATCH 03/25] xfstests: kill useless test owner fields Dave Chinner
2013-03-22 16:57 ` Phil White
2013-03-15 12:27 ` [PATCH 04/25] xfstests: remove stale machine configs Dave Chinner
2013-03-22 17:02 ` Phil White
2013-03-15 12:27 ` [PATCH 05/25] xfstests: fold common into check Dave Chinner
2013-03-23 10:18 ` Phil White
2013-03-15 12:27 ` [PATCH 06/25] xfstests: clean up and simply check CLI option parsing Dave Chinner
2013-03-23 10:19 ` Phil White
2013-03-15 12:27 ` [PATCH 07/25] xfstests: kill hangcheck stuff from check Dave Chinner
2013-03-23 10:19 ` Phil White
2013-03-15 12:27 ` [PATCH 08/25] xfstests: remove test expunge file support Dave Chinner
2013-03-23 10:19 ` Phil White
2013-03-15 12:27 ` [PATCH 09/25] xfstests: remove undocumented TESTS_REMAINING_LOG Dave Chinner
2013-03-23 10:20 ` Phil White [this message]
2013-03-15 12:27 ` [PATCH 10/25] xfstests: include test subdirectory support Dave Chinner
2013-03-23 10:20 ` Phil White
2013-03-15 12:27 ` [PATCH 11/25] xfstests: remove 285.full and 286.full Dave Chinner
2013-03-23 10:20 ` Phil White
2013-03-15 12:27 ` [PATCH 12/25] xfstests: move generic tests out of top level dir Dave Chinner
2013-03-23 10:22 ` Phil White
2013-03-15 12:27 ` [PATCH 13/25] xfstests: move xfs specific tests out of top directory Dave Chinner
2013-03-23 10:22 ` Phil White
2013-03-15 12:27 ` [PATCH 14/25] xfstests: move remaining tests out of top level directory Dave Chinner
2013-03-23 10:23 ` Phil White
2013-03-15 12:27 ` [PATCH 15/25] xfstests: rework CLI individual test specification Dave Chinner
2013-03-23 10:23 ` Phil White
2013-03-15 12:28 ` [PATCH 16/25] xfstests: make exclude groups aware of multiple subdirectories Dave Chinner
2013-03-23 10:23 ` Phil White
2013-03-15 12:28 ` [PATCH 17/25] xfstests: Introduce a results directory Dave Chinner
2013-03-23 10:23 ` Phil White
2013-03-15 12:28 ` [PATCH 18/25] xfstests: convert tests to use new " Dave Chinner
2013-03-23 10:24 ` Phil White
2013-03-15 12:28 ` [PATCH 19/25] xfstests: fix _link_out_file callers Dave Chinner
2013-03-23 10:24 ` Phil White
2013-03-15 12:28 ` [PATCH 20/25] xfstests: introduce a common directory Dave Chinner
2013-03-23 10:24 ` Phil White
2013-03-15 12:28 ` [PATCH 21/25] xfstests: Reintroduce configurable test expunging Dave Chinner
2013-03-23 10:24 ` Phil White
2013-03-15 12:28 ` [PATCH 22/25] xfstests: RESULTS_DIR needs to be an absolute path Dave Chinner
2013-03-23 10:24 ` Phil White
2013-03-15 12:28 ` [PATCH 23/25] xfstests: Decomplicate quota setup in 050 Dave Chinner
2013-03-23 10:24 ` Phil White
2013-03-15 12:28 ` [PATCH 24/25] xfstests: clean up test 262 output file use Dave Chinner
2013-03-23 10:24 ` Phil White
2013-03-15 12:28 ` [PATCH 25/25] xfstests: use _notrun for tape checks Dave Chinner
2013-03-23 10:24 ` Phil White
2013-03-27 10:51 ` [PATCH 00/25] xfstests: xfstests: move tests out of top level Rich Johnston
2013-03-27 10:51 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130323102016.GM25253@caliban.engr.sgi.com \
--to=pwhite@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox