From: Dave Chinner <david@fromorbit.com>
To: Pedro Ribeiro <pedrib@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: Crash with 3.8.3 and TuxOnIce
Date: Thu, 28 Mar 2013 11:51:06 +1100 [thread overview]
Message-ID: <20130328005106.GY6369@dastard> (raw)
In-Reply-To: <CAEDdjHdj9QD3OybyJwahpBDA=i8nxeLufaHDT0c9EEfdotp1Pw@mail.gmail.com>
On Wed, Mar 27, 2013 at 09:58:43PM +0000, Pedro Ribeiro wrote:
> Hi Dave (and others),
>
> I've pretty much established the responsible: commit
> 437a255aa23766666aec78af63be4c253faa8d57
> (
> http://git.kernel.org/cgit/linux/kernel/git/stable/stable-queue.git/tree/releases/3.7.2/xfs-fix-direct-io-nested-transaction-deadlock.patch?id=HEAD
> ).
Seems completely unrelated to the problem you saw.
> Without this patch, the computer does not lock up in hibernate. So I
> understand that this is most likely a bug in ToI, not in xfs. Does this
> give you a better idea of how to solve the problem?
No.
> The only xfs-specific
> patch in ToI is below:
>
> diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
> index 0eda725..55de808 100644
> --- a/fs/xfs/xfs_trans_ail.c
> +++ b/fs/xfs/xfs_trans_ail.c
> @@ -511,6 +511,7 @@ xfsaild(
> struct xfs_ail *ailp = data;
> long tout = 0; /* milliseconds */
>
> + set_freezable();
> current->flags |= PF_MEMALLOC;
We do not ever set the PF_NOFREEZE, so set_freezable() is a no-op.
If ToI has introduced new freeze API dependencies, then I'm not
going to try to understand or fix them.
> while (!kthread_should_stop()) {
>
> Looking at the code blindly, it appears to be similar to what goes on in
> other filesystems...
That loop has a call to try_to_freeze() in it, which is how such
kthreads are supposed to handle freezing. i.e. once they enter a
state in which they can freeze, they call try_to_freeze() and then
get moved to the refrigerator.
You need to talk to the ToI developers...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-28 0:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 23:31 Crash with 3.8.3 and TuxOnIce Pedro Ribeiro
2013-03-20 0:44 ` Dave Chinner
2013-03-20 18:01 ` Pedro Ribeiro
2013-03-21 1:01 ` Dave Chinner
2013-03-21 17:45 ` Pedro Ribeiro
2013-03-27 21:58 ` Pedro Ribeiro
2013-03-28 0:51 ` Dave Chinner [this message]
2013-03-27 23:39 ` Ben Myers
2013-03-28 0:51 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130328005106.GY6369@dastard \
--to=david@fromorbit.com \
--cc=pedrib@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox