Re: [PATCH 10/21] xfs: add CRC checks to remote symlinks

Ben Myers
2013-03-20T21:15:00Z

Hi Dave,

On Tue, Mar 12, 2013 at 11:30:43PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Add a header to the remote symlink block, containing location and
> owner information, as well as CRCs and LSN fields. This requires
> verifiers to be added to the remote symlink buffers for CRC enabled
> filesystems.
>
> This also fixes a bug reading multiple block symlinks, where the second block
> overwrites the first block when copying out the link name.

Huh. This commit message doesn't say anything about moving symlink related
code from xfs_vnodeops.c to a new file xfs_symlink.c. If you're going to cut
and paste code en masse from one file to the next, that's perfectly fine with
me. But please do that in a separate patch than the code you're adding for a
feature so that I can focus on the new code in the review.

Looks like you need to add a GPL notice.

Thanks,
Ben