From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 651E67F4C for ; Mon, 8 Apr 2013 18:07:41 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 00466AC002 for ; Mon, 8 Apr 2013 16:07:37 -0700 (PDT) Received: from ipmail06.adl6.internode.on.net (ipmail06.adl6.internode.on.net [150.101.137.145]) by cuda.sgi.com with ESMTP id QnrQSIIEBb4WLcZ2 for ; Mon, 08 Apr 2013 16:07:36 -0700 (PDT) Date: Tue, 9 Apr 2013 09:07:34 +1000 From: Dave Chinner Subject: Re: xfstests should still make xfs as default? Message-ID: <20130408230733.GB17758@dastard> References: <20130327203231.GA26739@andromeda.usersys.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130327203231.GA26739@andromeda.usersys.redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Carlos Maiolino Cc: xfs@oss.sgi.com On Wed, Mar 27, 2013 at 05:32:32PM -0300, Carlos Maiolino wrote: > Hi, working on xfstests after its new directory structures I noticed we should > use now something like: > > ./check xfs/ > > to run some tests, IMHO this is not intuitive and I was working on a patch to > make us able to use something just like the old way: > > ./check What do you do with duplicate test names? The main reason that the interface changed was to keep the changes to the test harness down to a minimum as it was just moving tests around. All that code needs to be revisited to support arbitrary test names, so there wasn't much point in doing a massive rework only to have to rework it again... But the question is: is the old way a sane way to specify tests in the brave new world? I'd much prefer that test specification is explict, and doesn't implicitly select tests. Indeed, if it implicitly selects tests (e.g. when there are duplicates it runs all duplicates) then we still need a method for running specific tests..... Note that what you are seeing is how the $have_test_arg code processes the test name. It requires that you tell it the directory so it knows where to look for the specific test. You could make it look in each test directory like get_group_list()/get_all_tests() do so we don't need to specify a directory. > But, since xfstests is becoming more generalist than xfs specific, I wonder if > we should still keep xfs as default. The default is whatever filesystem is on the $TEST_DEV, and I don't see that changing. i.e. what we set FSTYP to is the default. Note that get_group_list() and get_all_tests() specifically include the FSTYP directory, Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs