public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: xfstests: heads up about coreutils v8.20+ related failures
Date: Thu, 11 Apr 2013 19:45:12 +1000	[thread overview]
Message-ID: <20130411094512.GL10481@dastard> (raw)

Folks,

Debian unstable just transistined to coreutils v8.20 recently, ad
this has caused a bunch of tests to fail due to golden output
mismatches.

A while back, various GNU projects have decided to use the gcc quote
method, which means that the longstanding format of output messages
has changed to what gcc has been using for some time.

This is the typical sort of diff you'll see in a failure:

-mv: cannot move `TEST_DIR/test-mv/ab/aa/' to `TEST_DIR/test-mv/aa': File exists
+mv: cannot move 'TEST_DIR/test-mv/ab/aa/' to 'TEST_DIR/test-mv/aa': File exists

It's subtle, but the difference is `...' vs '...'.(*)

What this means is that we are going to have to add filters to all
the coreutils output in xfstests to convert the quotes to a common
format for the golden output.

I'm not going to get to this in the next couple of weeks (travel to
LF collab summit/LSFMM next week), so someone else might want to
have a look at this in the mean time...

Cheers,

Dave.

(*) Well, it's even more subtle than that, because I've had problems
with GCC quotes for years - they simply don't don't copy-n-paste
very well, even when all terminals and machines are using the same
locale and UTF-8 aware applications:

v8.13
$ LC_ALL=en_AU.UTF-8 mv a /etc
mv: cannot move `a' to `/etc/a': Permission denied

v8.20:
$ LC_ALL=en_AU.UTF-8 mv a /etc
mv: cannot move ¿a¿ to ¿/etc/a¿: Permission denied

Yeah, the quotes from v8.20 didn't paste as quotes. gcc has
displayed this behaviour for years, and now coreutils will behave
the same. Welcome to the wonderful new world of screwed up quotes in
bug reports....
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

                 reply	other threads:[~2013-04-11  9:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130411094512.GL10481@dastard \
    --to=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox