From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id E6F517F37 for ; Tue, 16 Apr 2013 13:26:27 -0500 (CDT) Date: Tue, 16 Apr 2013 13:26:24 -0500 From: Ben Myers Subject: Re: [PATCH] xfs: don't return 0 if generic_segment_checks() find nothing to write Message-ID: <20130416182624.GK22182@sgi.com> References: <51682CCC.308@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <51682CCC.308@oracle.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Jeff Liu Cc: "xfs@oss.sgi.com" Hey Jeff, On Fri, Apr 12, 2013 at 11:48:28PM +0800, Jeff Liu wrote: > From: Jie Liu > > At xfs_file_aio_write(), we just return 0 which means a successfully operation if the ocount > is evaluated to 0 at generic_segment_checks(). Generally, it'll occurred if the specified > write count is 0 from the user space. However, for example, if the given offset is over the > maximum file size limitation although nothing would be written into the file, in this case, > the underlying file system should detect this issue and return a proper errno instead. > Hence, the beginning pre-checking up against ocount would conceal some real cause and confuse > the user space program maybe. > > To fix it, we can delay the write count verification until xfs_file_aio_write_checks() is done. Could you wrap these around 72 columns or so in the future? Don't worry about reposting this one unless something technical comes up. Thanks, Ben _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs