From: Dave Chinner <david@fromorbit.com>
To: rjohnston@sgi.com
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprogs: xfs_quota allow user or group names beginning with digits
Date: Mon, 22 Apr 2013 12:45:01 +1000 [thread overview]
Message-ID: <20130422024501.GH13938@destitution> (raw)
In-Reply-To: <20130417183323.465181485@sgi.com>
On Wed, Apr 17, 2013 at 01:32:53PM -0500, rjohnston@sgi.com wrote:
> xfs_quota does not properly parse users or groups that begin with a number.
> Only call atoi when user or group consists of digits only.
>
> Signed-off-by: Rich Johnston <rjohnston@sgi.com>
>
> ---
> include/input.h | 1 +
> libxcmd/input.c | 12 ++++++++++++
> quota/quota.c | 4 ++--
> quota/quota.h | 1 +
> 4 files changed, 16 insertions(+), 2 deletions(-)
>
> Index: b/include/input.h
> ===================================================================
> --- a/include/input.h
> +++ b/include/input.h
> @@ -46,6 +46,7 @@ extern void timestr(struct timeval *tv,
> extern uid_t uid_from_string(char *user);
> extern gid_t gid_from_string(char *group);
> extern prid_t prid_from_string(char *project);
> +extern boolean_t isdigits_only(const char *str);
bool is the correct type, not boolean_t. My CRC patchset makes
userspace fall in line with the removal of boolean_t from the kernel
code, so we should probably make this correct from the start. ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-04-22 2:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 18:32 [PATCH] xfsprogs: xfs_quota allow user or group names beginning with digits rjohnston
2013-04-21 5:55 ` Eric Sandeen
2013-04-22 2:45 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130422024501.GH13938@destitution \
--to=david@fromorbit.com \
--cc=rjohnston@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox