From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id E93017F37 for ; Sun, 28 Apr 2013 18:25:52 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id A9419304059 for ; Sun, 28 Apr 2013 16:25:49 -0700 (PDT) Received: from ipmail06.adl6.internode.on.net (ipmail06.adl6.internode.on.net [150.101.137.145]) by cuda.sgi.com with ESMTP id eHR6YnwqdhykMkFs for ; Sun, 28 Apr 2013 16:25:47 -0700 (PDT) Date: Mon, 29 Apr 2013 09:25:43 +1000 From: Dave Chinner Subject: Re: [PATCH 00/22] xfs: metadata CRCs, fourth version Message-ID: <20130428232543.GW10481@dastard> References: <1364965892-19623-1-git-send-email-david@fromorbit.com> <20130427204258.GI29359@sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130427204258.GI29359@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Ben Myers Cc: xfs@oss.sgi.com On Sat, Apr 27, 2013 at 03:42:58PM -0500, Ben Myers wrote: > Hi Dave, > > On Wed, Apr 03, 2013 at 04:11:10PM +1100, Dave Chinner wrote: > > New CRC patchset. Previous versions: > > > > http://oss.sgi.com/archives/xfs/2013-01/msg00328.html > > http://oss.sgi.com/archives/xfs/2013-02/msg00451.html > > http://oss.sgi.com/archives/xfs/2013-03/msg00291.html > > > > This version is based on 3.9-rc4 + TOT xfsdev. 3.9-rc5 has loopback > > bugs that make it useless for testing, so I've just kept my tree on > > -rc4. > > > > New in this patch set: > > > > - numerous bug fixes > > - cleanups to addresse Bens review comments > > - logs entire inode allocation buffers > > - reworks the buffer type tracking for log recovery > > - fixes the endian issues reported by sparse > > - splits out the symlink code rearrangement > > - adds support for v5 superblock feature masks > > - add mount warnings about CRC support being experimental > > > > Still to do: > > > > - Documentation (half written, not in series) > > - DT_* type fields in the directory entries. This can be > > done with a feature bit if not done in time. > > - storage of attributes larger than 256 bytes in shortform > > attribute forks. Same comment about a feature bit. > > > > The addition of the feature mask support to the superblock added a > > new field to the superblock - a log compatibility feature mask. This > > is to allow new transactions and recovery features to be added and > > prevent kernels that don't understand those features from performing > > log recovery. The idea is that clean logs can be mounted by kernels > > that don't support the new feature if everything else is compatible, > > but if they require log recovery the mount will be aborted. This > > means pure log changes don't require a compat/incompat/rocompat > > feature bit to be set. > > > > The result of adding this is that all the old CRC enabled > > filesystems will not work with this kernel - the CRC field location > > changed, and that makes the mount fail hard. So a new userspace will > > be needed to test the CRC side of this patchset. (Coming soon!) > > > > Comments, testing welcome... > > I've pulled in this series. There are still a few outstanding questions > from review. I'm confident that we can get them sorted in the coming week. > > Reviewed-by: Ben Myers Fantastic, Ben. Thank you for all your time reviewing it. I'll send fixes for your outstanding review comments as incremental patches on top of the current tree now... Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs