From: Dave Chinner <david@fromorbit.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests 311: test fsync with dm flakey V3
Date: Tue, 30 Apr 2013 17:38:33 +1000 [thread overview]
Message-ID: <20130430073833.GI23072@dastard> (raw)
In-Reply-To: <1367003639-17621-1-git-send-email-jbacik@fusionio.com>
On Fri, Apr 26, 2013 at 03:13:59PM -0400, Josef Bacik wrote:
> This test sets up a dm flakey target and then runs my fsync tester I've been
> using to verify btrfs's fsync() is working properly. It will create a dm flakey
> device, mount it, run my test, make the flakey device start dropping writes, and
> then unmount the fs. Then we mount it back up and make sure the md5sums match
> and then run fsck on the device to make sure we got a consistent fs. I used the
> output from a run on BTRFS since it's the only one that passes this test
> properly. I verified each test manually to make sure they were in fact valid
> files. XFS and Ext4 both fail this test in one way or another. Thanks,
>
> Signed-off-by: Josef Bacik <jbacik@fusionio.com>
> ---
> V2->V3:
> -encorporate all of Dave Chinners feedback
> -expand the testing to run the tests with normal dmsetup suspend and with
> --nolockfs
I haven't tested the new version yet, but all the changes I asked
for look good now.
Acked-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-04-30 7:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 19:13 [PATCH] xfstests 311: test fsync with dm flakey V3 Josef Bacik
2013-04-30 7:38 ` Dave Chinner [this message]
2013-05-03 12:28 ` Rich Johnston
2013-05-03 17:30 ` Josef Bacik
2013-05-03 18:01 ` Rich Johnston
2013-05-03 18:21 ` Rich Johnston
2013-05-03 19:05 ` Josef Bacik
2013-05-03 19:26 ` Rich Johnston
2013-05-06 0:19 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130430073833.GI23072@dastard \
--to=david@fromorbit.com \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox