From: Ben Myers <bpm@sgi.com>
To: James Dingwall <james.dingwall@zynstra.com>
Cc: xfs@oss.sgi.com
Subject: Re: Cleancache support in XFS
Date: Wed, 1 May 2013 11:20:44 -0500 [thread overview]
Message-ID: <20130501162044.GN29359@sgi.com> (raw)
In-Reply-To: <51810CED.4080003@zynstra.com>
Hi James,
On Wed, May 01, 2013 at 01:39:09PM +0100, James Dingwall wrote:
> In reference to: http://oss.sgi.com/archives/xfs/2012-05/msg00046.html
>
> $ grep -r cleancache fs/xfs
> on the 3.9 kernel source suggests that no patch was submitted to
> enable cleancache for the XFS filesystem. Since it was suggested
> that this could be a one liner I've had a go and my first effort is
> inline below. While this seems to compile OK I have no experience
> in filesystems so I would appreciate it if anyone can point out that
> it is obviously wrong and likely to eat my data before I try booting
> the kernel.
>
> If it seems a reasonable attempt what would be the best way to check
> that it isn't doing nasty things?
Hrm.. Looks like there is a doc in Documentation/vm/cleancache.txt which
includes a list of attributes the filesystem needs to have to work properly
with cleancache. I'd suggest going over that list and the code by inspection
first, followed by some xfstests runs, and then wait for it to make a release
before trusting any data to it. For a test machine that I'm willing to crater,
no worries. But I wouldn't run this on my main workstation without doing the
above first. We can probably explore this for 3.11. Thanks for the patch.
Regards,
Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-01 16:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 12:39 Cleancache support in XFS James Dingwall
2013-05-01 16:20 ` Ben Myers [this message]
2013-05-01 22:30 ` Dave Chinner
2013-05-02 8:24 ` James Dingwall
2013-05-22 19:28 ` Konrad Rzeszutek Wilk
2013-05-24 7:30 ` James Dingwall
2013-06-07 17:08 ` Konrad Rzeszutek Wilk
2013-07-19 7:18 ` James Dingwall
2013-07-22 15:48 ` Konrad Rzeszutek Wilk
2013-07-23 7:23 ` James Dingwall
2013-07-23 8:27 ` Dave Chinner
2013-07-23 8:53 ` James Dingwall
2013-11-21 13:35 ` James Dingwall
2013-11-21 16:07 ` Ben Myers
2013-11-21 22:12 ` Dave Chinner
2013-11-26 16:35 ` Konrad Rzeszutek Wilk
2013-11-26 16:35 ` Konrad Rzeszutek Wilk
2013-05-13 8:59 ` James Dingwall
-- strict thread matches above, loose matches on Subject: below --
2012-04-30 17:31 Alexey Vlasov
2012-04-30 19:12 ` Christoph Hellwig
2012-05-02 8:02 ` Alexey Vlasov
2012-05-05 23:40 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130501162044.GN29359@sgi.com \
--to=bpm@sgi.com \
--cc=james.dingwall@zynstra.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox