Re: xfsprogs-3.1.11 pre-release please test!

From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Rich Johnston <rjohnston@sgi.com>,
	Mark Tinguely <tinguely@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: xfsprogs-3.1.11 pre-release   please test!
Date: Thu, 2 May 2013 08:10:07 +1000	[thread overview]
Message-ID: <20130501221007.GP10481@dastard> (raw)
In-Reply-To: <518187D0.6000809@sandeen.net>

On Wed, May 01, 2013 at 04:23:28PM -0500, Eric Sandeen wrote:
> On 5/1/13 4:17 PM, Mark Tinguely wrote:
> > On 05/01/13 16:01, Eric Sandeen wrote:
> >> On 5/1/13 3:35 PM, Mark Tinguely wrote:
> >>> On 05/01/13 15:12, Rich Johnston wrote:
> >>>> I have placed a pre-release tarball here:
> >>>>
> >>>> ftp://oss.sgi.com/projects/xfs/cmd_tars/pre-release/xfsprogs-pre-3.1.11-3.tar.gz
> >>>>
> >>>>
> >>>> Please take a look and report any issues before next Wednesday (08 May
> >>>> 2013). If there are other patches which you feel are essential, now is
> >>>> the time to say so.
> >>>>
> >>>> Regards
> >>>> --Rich
> >>>
> >>> The new lines (below) in xfs_check.sh breaks older xfstests:
> >>>
> >>>    xfs_check is deprecated and scheduled for removal in June 2014.
> >>>    Please use xfs_repair -n<dev>  instead.
> >>
> >> Hum, I thought xfstests stopped calling xfs_check.sh and implemented
> >> its own xfs_check internally:
> >>
> >> commit 187bccd310dc253feaebd69df4ccdda21eee12d0
> >> Author: Chandra Seetharaman<sekharan@us.ibm.com>
> >> Date:   Thu Apr 18 17:44:02 2013 +0000
> >>
> >>      xfstests: Remove dependence of xfs_check script
> >>
> >>      Replace the usage of the script xfs_check and add the relevant code to
> >>      xfstests.
> >>
> >> ...
> >> -        [ "$XFS_CHECK_PROG" = "" ]&&  _fatal "xfs_check not found"
> >> ... etc ...
> >>
> >> where is check getting called directly?
> >>
> >> (Or: is your xfstests up to date?)
> >>
> >> -Eric
> > 
> > I disclosed it as an older xfstests.
> 
> Sorry, I missed that.
> 
> > It is conceivable that people will install the latest xfsprogs and not upgrade xfstests. I can hear it now, "It used to just work..." :)
> 
> So what's the proposed solution? ;)

Upgrade xfstests.

> TBH I think xfstests is the kind of thing that is in so much flux
> you should always assume you need a newer version.

That has always been the case.

> And since it's mostly qe/devel types using it, I'd submit that
> they can figure it out, but if you have a better idea, I'm all
> ears!

Given the number of people that are likely to hit this, then I think
leaving it as it stands is just fine. The expectation is that you
should be using an xfstests that matches the age of your userspace
tools, otherwise you are not going be running all the tests necessary
to exercise the current userspace functionality you have installed...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs