From: Dave Chinner <david@fromorbit.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: Mark Tinguely <tinguely@sgi.com>, "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH 2/2 v2] xfs: Don't keep silent if sunit/swidth can not be changed via mount
Date: Thu, 2 May 2013 17:20:24 +1000 [thread overview]
Message-ID: <20130502072024.GX10481@dastard> (raw)
In-Reply-To: <51820D8E.7040308@oracle.com>
On Thu, May 02, 2013 at 02:54:06PM +0800, Jeff Liu wrote:
> On 05/02/2013 09:13 AM, Dave Chinner wrote:
> > On Wed, May 01, 2013 at 10:25:19PM +0800, Jeff Liu wrote:
> >> diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
> >> index 29e8de8..2836ef6 100644
> >> --- a/fs/xfs/xfs_mount.c
> >> +++ b/fs/xfs/xfs_mount.c
> >> @@ -909,6 +909,10 @@ xfs_update_alignment(xfs_mount_t *mp)
> >> sbp->sb_width = mp->m_swidth;
> >> mp->m_update_flags |= XFS_SB_WIDTH;
> >> }
> >> + } else {
> >> + xfs_warn(mp, "cannot change alignment: "
> >> + "superblock does not support data alignment");
> >
> > Same comment again about single line format strings. Otherwise it's
> > ok.
> Ah, sorry! I misunderstood the comments of Mark before. I was bluffed
> into believing that I should cut the length of log string as short as
> possible. :(
Thing of being able cut-n-paste the error message out of the log and
then being able to grep the source tree for it. i.e.
$ git grep "cannot change alignment: superblock does not support data alignment"
Will fail to find anything in the former case, but in the single
line case it will identify the file the error lies in immediately.
So the question I always ask myself is "is that format string easy
to find with grep?" :)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-02 7:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 14:25 [PATCH 2/2 v2] xfs: Don't keep silent if sunit/swidth can not be changed via mount Jeff Liu
2013-05-02 1:13 ` Dave Chinner
2013-05-02 6:54 ` Jeff Liu
2013-05-02 7:20 ` Dave Chinner [this message]
2013-05-02 10:56 ` Jeff Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130502072024.GX10481@dastard \
--to=david@fromorbit.com \
--cc=jeff.liu@oracle.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox