From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix sub-page blocksize data integrity writes
Date: Thu, 2 May 2013 17:58:36 +1000 [thread overview]
Message-ID: <20130502075836.GY10481@dastard> (raw)
In-Reply-To: <1367480709-23804-1-git-send-email-david@fromorbit.com>
On Thu, May 02, 2013 at 05:45:09PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> FSX on 512 byte block size filesystems has been failing for some
> time with corrupted data. The fault dates back to the change in
> the writeback data integrity algorithm that uses a mark-and-sweep
> approach to avoid data writeback livelocks.
.....
> + * time this will be the only page inteh file that needs writeback.
> + * Hence for more optimal IO patterns, we should always avoid partial
> + * page writeback due to multiple mappings on a page here.
> + */
> + if (!xfs_imap_valid(inode, imap, end_offset))
> + goto fail_unlock_page;
> +
> len = 1 << inode->i_blkbits;
> p_offset = min_t(unsigned long, end_offset & (PAGE_CACHE_SIZE - 1),
> PAGE_CACHE_SIZE);
> p_offset = p_offset ? roundup(p_offset, len) : PAGE_CACHE_SIZE;
> page_dirty = p_offset / len;
>
> +
Oh, stray whitespace....
> bh = head = page_buffers(page);
> do {
> if (offset >= end_offset)
> diff --git a/fs/xfs/xfs_vnodeops.c b/fs/xfs/xfs_vnodeops.c
> index 1501f4f..0176bb2 100644
> --- a/fs/xfs/xfs_vnodeops.c
> +++ b/fs/xfs/xfs_vnodeops.c
> @@ -1453,7 +1453,7 @@ xfs_free_file_space(
> xfs_mount_t *mp;
> int nimap;
> uint resblks;
> - uint rounding;
> + xfs_off_t rounding;
> int rt;
> xfs_fileoff_t startoffset_fsb;
> xfs_trans_t *tp;
> @@ -1482,7 +1482,7 @@ xfs_free_file_space(
> inode_dio_wait(VFS_I(ip));
> }
>
> - rounding = max_t(uint, 1 << mp->m_sb.sb_blocklog, PAGE_CACHE_SIZE);
> + rounding = max_t(xfs_off_t, 1 << mp->m_sb.sb_blocklog, PAGE_CACHE_SIZE);
> ioffset = offset & ~(rounding - 1);
> error = -filemap_write_and_wait_range(VFS_I(ip)->i_mapping,
> ioffset, -1);
And I forgot I had noticed a second problem while dealing with this
one (i.e. the rounding masks is wrong for offsets > 32 bits)....
I'll repost them both as separate patches.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-05-02 7:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 7:45 [PATCH] xfs: fix sub-page blocksize data integrity writes Dave Chinner
2013-05-02 7:58 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130502075836.GY10481@dastard \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox