From: Ben Myers <bpm@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: xfs: fallback to vmalloc for large buffers in xfs_attrlist_by_handle
Date: Tue, 7 May 2013 19:01:52 -0500 [thread overview]
Message-ID: <20130508000152.GR29359@sgi.com> (raw)
In-Reply-To: <515D0A09.5030808@sandeen.net>
On Thu, Apr 04, 2013 at 12:05:13AM -0500, Eric Sandeen wrote:
> On 4/3/13 10:52 PM, Dave Chinner wrote:
> > On Wed, Apr 03, 2013 at 03:52:49PM -0700, Linda Walsh wrote:
> >>
> >> Note -- I might have more attributes than some as the disks are shared via samba
> >> w/windows
> >> and samba stores ACL and xattr info from windows in xfs's attrs...
> >>
> >>
> >> xfsdump: WARNING: could not get list of root attributes for nondir ino
> >> 3412893285: Cannot allocate memory (12)
> >
> > ....
> >> [1007383.689492] xfsdump: page allocation failure: order:4, mode:0x10c0d0
> > ....
> >> [1007383.689531] [<ffffffff81143a54>] kmalloc_order_trace+0x34/0xe0
> >> [1007383.689534] [<ffffffff81146546>] __kmalloc+0x186/0x190
> >> [1007383.689541] [<ffffffff8124263c>] xfs_attrlist_by_handle+0x8c/0x110
> >> [1007383.689544] [<ffffffff81243487>] xfs_file_ioctl+0x437/0xb60
> >
> > So it's the attribute handle interfaces that need the vmalloc
> > treatment here, just like has been done for all the other attribute
> > interfaces....
>
> Like this?
>
> From: Eric Sandeen <sandeen@redhat.com>
>
> xfs: fallback to vmalloc for large buffers in xfs_attrlist_by_handle
>
> Shamelessly copied from dchinner's:
> ad650f5b xfs: fallback to vmalloc for large buffers in xfs_attrmulti_attr_get
>
> xfsdump uses for a large buffer for extended attributes, which has a
> kmalloc'd shadow buffer in the kernel. This can fail after the
> system has been running for some time as it is a high order
> allocation. Add a fallback to vmalloc so that it doesn't require
> contiguous memory and so won't randomly fail while xfsdump is
> running.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Applied.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-05-08 0:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 22:52 xfsdump having problems dumping attributes again (cannot allocate memory) Linda Walsh
2013-04-04 3:39 ` Linda Walsh
2013-04-04 3:52 ` Dave Chinner
2013-04-04 5:05 ` [PATCH] xfs: xfs: fallback to vmalloc for large buffers in xfs_attrlist_by_handle Eric Sandeen
2013-04-04 6:57 ` Linda Walsh
2013-04-16 13:37 ` Mark Tinguely
2013-04-25 16:13 ` [PATCH] xfs: xfs: fallback to vmalloc for large buffers in xfs_compat_attrlist_by_handle Eric Sandeen
2013-04-25 16:43 ` Mark Tinguely
2013-05-08 0:01 ` Ben Myers
2013-05-08 0:01 ` Ben Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130508000152.GR29359@sgi.com \
--to=bpm@sgi.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox