From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 236C529E0E for ; Tue, 7 May 2013 21:41:31 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id 0844A304051 for ; Tue, 7 May 2013 19:41:30 -0700 (PDT) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id sgSOtqkKBKvpWuXf for ; Tue, 07 May 2013 19:41:29 -0700 (PDT) Date: Wed, 8 May 2013 12:41:25 +1000 From: Dave Chinner Subject: Re: [PATCH V2] xfstests: automatically add -F to xfs_io on non-xfs Message-ID: <20130508024124.GI24635@dastard> References: <51850BED.6050109@redhat.com> <5189B9DA.7010807@sandeen.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5189B9DA.7010807@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: Eric Sandeen , Jan Kara , xfs-oss On Tue, May 07, 2013 at 09:35:06PM -0500, Eric Sandeen wrote: > The -F flag to xfs_io originally enabled it to operate on non-xfs > filesystems. This restriction was removed upstream in favor of > gracefully failing on the handful of operations that actually > required xfs, and the option was deprecated. > > However, xfstests is still used on distros with older xfsprogs, and > so "xfs_io -F" was necessary throughout xfstests. > > Simplify this by appending -F to XFS_IO_PROG when it's needed - > i.e. if we're using old xfsprogs on a non-xfs filesystem. > > This will eliminate errors when new tests leave out the -F, and > if and when -F is finally removed, there will be one central > location in xfstests to update. > > Signed-off-by: Eric Sandeen > --- > > V2: test for necessity of -F in all cases, and convert > a bunch more direct callers of xfs_io to $XFS_IO_PROG Yup, that fixes the one concern I had with the first patch. Loks good. Acked-by: Dave Chinner Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs