From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfstests: quota not supported on realtime filesystems
Date: Thu, 9 May 2013 09:34:28 +1000 [thread overview]
Message-ID: <20130508233428.GK24635@dastard> (raw)
In-Reply-To: <518A6325.3030809@sandeen.net>
On Wed, May 08, 2013 at 09:37:25AM -0500, Eric Sandeen wrote:
> On 5/8/13 1:04 AM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Realtime XFS filesystems do not support quotas, so quota tests
> > always fail on such filesystems. Add a check to _require_quota to
> > detect this situation and notrun the quota tests...
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
>
> (PS why is USE_EXTERNAL a thing? if it's set, shouldn't it be used?)
Because if you have rtdev/logdev defined in your config, you can
choose whether to test them or not without having to modify the
config file. Very handy, really.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-05-08 23:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 6:04 [PATCH 0/2] xfstests: more simple fixes Dave Chinner
2013-05-08 6:04 ` [PATCH 1/2] xfstests: fix incorrect redirect in generic/233 Dave Chinner
2013-05-08 14:34 ` Eric Sandeen
2013-05-14 13:47 ` Rich Johnston
2013-05-08 6:04 ` [PATCH 2/2] xfstests: quota not supported on realtime filesystems Dave Chinner
2013-05-08 14:37 ` Eric Sandeen
2013-05-08 23:34 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130508233428.GK24635@dastard \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox